Skip to content

Enforce in bootstrap that test must have stage at least 1 (except for compiletest) #145663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 23 commits into from
Sep 1, 2025
Merged

Enforce in bootstrap that test must have stage at least 1 (except for compiletest) #145663

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a3ef817
Add snapshot test for `tier-check`
Kobzol Aug 8, 2025
65b7cde
Fixup `x test tier-check`
Kobzol Aug 8, 2025
542e750
Forbid running tests on stage 0 unless `build.compiletest-allow-stage…
Kobzol Aug 20, 2025
f0d15d3
Add snapshot test for `x test`
Kobzol Aug 20, 2025
a347f8d
Fix staging of `TestFloatParse`
Kobzol Aug 20, 2025
42fb65b
Remove `compiler_for` from `test::CodegenGCC`
Kobzol Aug 20, 2025
2ca5cb8
Remove `compiler_for` from `test::CodegenCranelift`
Kobzol Aug 20, 2025
e759b97
Refactor `test::LintDocs`
Kobzol Aug 20, 2025
0f2fc03
Remove stage0 checking
Kobzol Aug 20, 2025
1d96ef8
Small refactoring around `RemoteCopyLibs`
Kobzol Aug 20, 2025
384a044
Add metadata to a bunch of steps, rename variables and add comments
Kobzol Aug 20, 2025
6651686
Move the `test!` macro closer to its usages
Kobzol Aug 20, 2025
0b3a13c
Fix staging for compiler/std crate tests
Kobzol Aug 20, 2025
ef569d3
Fix spacing when testing individual crates
Kobzol Aug 20, 2025
dda8e1d
Do not run tests on CI in stage 0
Kobzol Aug 20, 2025
b53d532
Add change tracker entry
Kobzol Aug 20, 2025
425c66e
Skip bootstrap tests on CI
Kobzol Aug 20, 2025
1591901
Fix doclink
Kobzol Aug 20, 2025
1c1d630
Fake nodejs in snapshot test
Kobzol Aug 20, 2025
daaf0c9
Fix tests and doclink
Kobzol Aug 20, 2025
d2195c4
Add test stage 2 snapshot tests
Kobzol Aug 27, 2025
9de09ac
Fix stage 1 compiler tests
Kobzol Aug 25, 2025
5bc9308
Do not run `lint-docs` tests in stage 1 `x test` by default
Kobzol Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not run tests on CI in stage 0
  • Loading branch information
@Kobzol
Kobzol committed Aug 30, 2025
commit dda8e1ddc167264ef5b0cdff0c4a3e6c7fcdca43
2 changes: 1 addition & 1 deletion src/ci/docker/host-x86_64/tidy/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ RUN bash -c 'npm install -g eslint@$(cat /tmp/eslint.version)'

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 \
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck