Skip to content

rustdoc: a few micro-optimizations targeted at build_impl #145851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Aug 28, 2025
Merged

rustdoc: a few micro-optimizations targeted at build_impl #145851

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e969c7
rustdoc(opt): build_impl: check document_private earlier
lolbinarycat Aug 25, 2025
f16d1fc
use size_hint in attrs_to_doc_fragments
lolbinarycat Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
rustdoc(opt): build_impl: check document_private earlier
  • Loading branch information
@lolbinarycat
lolbinarycat committed Aug 25, 2025
commit 2e969c720b444420876a2b16cf10402553093a3c
34 changes: 17 additions & 17 deletions src/librustdoc/clean/inline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,30 +572,30 @@ pub(crate) fn build_impl(
super::build_deref_target_impls(cx, &trait_items, ret);
}

// Return if the trait itself or any types of the generic parameters are doc(hidden).
let mut stack: Vec<&Type> = vec![&for_];
if !document_hidden {
// Return if the trait itself or any types of the generic parameters are doc(hidden).
let mut stack: Vec<&Type> = vec![&for_];

if let Some(did) = trait_.as_ref().map(|t| t.def_id())
&& !document_hidden
&& tcx.is_doc_hidden(did)
{
return;
}

if let Some(generics) = trait_.as_ref().and_then(|t| t.generics()) {
stack.extend(generics);
}

while let Some(ty) = stack.pop() {
if let Some(did) = ty.def_id(&cx.cache)
&& !document_hidden
if let Some(did) = trait_.as_ref().map(|t| t.def_id())
&& tcx.is_doc_hidden(did)
{
return;
}
if let Some(generics) = ty.generics() {

if let Some(generics) = trait_.as_ref().and_then(|t| t.generics()) {
stack.extend(generics);
}

while let Some(ty) = stack.pop() {
if let Some(did) = ty.def_id(&cx.cache)
&& tcx.is_doc_hidden(did)
{
return;
}
if let Some(generics) = ty.generics() {
stack.extend(generics);
}
}
}

if let Some(did) = trait_.as_ref().map(|t| t.def_id()) {
Expand Down