feat: non-panicking Vec::try_remove
#146293
Merged
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
BenjaminBrienen
changed the title
Vec::try_remove
BenjaminBrienen
force-pushed
the
try_remove
branch
from
7d39eb5 to
bea4dd2
Compare
This comment has been minimized.
This comment has been minimized.
BenjaminBrienen
force-pushed
the
try_remove
branch
from
bea4dd2 to
128b441
Compare
This comment has been minimized.
This comment has been minimized.
|
Looks like I inadvertently repeated #77480 I'd still like to reopen the discussion about this. |
folkertdev
reviewed
Sep 7, 2025
There was a problem hiding this comment.
Additions to the standard library APIs will need an ACP first, see https://github.com/rust-lang/libs-team/issues > new issue > Api Change Proposal
This comment has been minimized.
This comment has been minimized.
BenjaminBrienen
force-pushed
the
try_remove
branch
2 times, most recently
from
5bf4f7d to
c2ffa8a
Compare
Added the tracking issue to the description. Is that sufficient? Edit: added an ACP |
tgross35
added
the
S-waiting-on-ACP
|
r? libs |
3 tasks
joboet
approved these changes
Sep 24, 2025
joboet
removed
the
S-waiting-on-ACP
|
Oh, and could you squash the commits, please? |
BenjaminBrienen
force-pushed
the
try_remove
branch
from
59a4d73 to
9a4c40a
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
joboet
reviewed
Sep 24, 2025
Vec::try_remove is a non-panicking version of Vec::remove
BenjaminBrienen
force-pushed
the
try_remove
branch
from
9a4c40a to
5673449
Compare
|
Great, thank you! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 25, 2025
feat: non-panicking `Vec::try_remove`
`if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }` is annoying to write and non-panicking functions are broadly useful.
APC: rust-lang/libs-team#649
Tracking issue: rust-lang#146954
This was referenced Sep 25, 2025
bors
added a commit
that referenced
this pull request
Sep 25, 2025
Rollup of 8 pull requests Successful merges: - #116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`) - #142401 (Add proper name mangling for pattern types) - #146293 (feat: non-panicking `Vec::try_remove`) - #146859 (BTreeMap: Don't leak allocators when initializing nodes) - #146924 (Add doc for `NonZero*` const creation) - #146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 25, 2025
Rollup merge of #146293 - BenjaminBrienen:try_remove, r=joboet feat: non-panicking `Vec::try_remove` `if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }` is annoying to write and non-panicking functions are broadly useful. APC: rust-lang/libs-team#649 Tracking issue: #146954
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 26, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI) - rust-lang/rust#135771 ([rustdoc] Add support for associated items in "jump to def" feature) - rust-lang/rust#141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`) - rust-lang/rust#142401 (Add proper name mangling for pattern types) - rust-lang/rust#146293 (feat: non-panicking `Vec::try_remove`) - rust-lang/rust#146859 (BTreeMap: Don't leak allocators when initializing nodes) - rust-lang/rust#146924 (Add doc for `NonZero*` const creation) - rust-lang/rust#146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }is annoying to write and non-panicking functions are broadly useful.APC: rust-lang/libs-team#649
Tracking issue: #146954