Skip to content

tidy: make behavior of extra-checks more uniform #146332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Sep 12, 2025
Merged

tidy: make behavior of extra-checks more uniform #146332

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
469a80e
all tidy extra checks now print what they do in present tense
lolbinarycat Sep 8, 2025
a9d884d
tidy: py:lint extra check now works with --bless
lolbinarycat Sep 8, 2025
c19d81b
tidy extra checks that interact with --bless now all recommend using it
lolbinarycat Sep 8, 2025
8222f7d
tidy extra checks: use Error::FailedCheck correctly
lolbinarycat Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tidy extra checks: use Error::FailedCheck correctly
  • Loading branch information
@lolbinarycat
lolbinarycat committed Sep 8, 2025
commit 8222f7d95bee2b91bddfd87a43949e4583047363
6 changes: 3 additions & 3 deletions src/tools/tidy/src/extra_checks/rustdoc_js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ fn run_eslint(
if exit_status.success() {
return Ok(());
}
Err(super::Error::FailedCheck("eslint command failed"))
Err(super::Error::FailedCheck("eslint"))
}
Err(error) => Err(super::Error::Generic(format!("eslint command failed: {error:?}"))),
}
Expand Down Expand Up @@ -94,7 +94,7 @@ pub(super) fn typecheck(outdir: &Path, librustdoc_path: &Path) -> Result<(), sup
if exit_status.success() {
return Ok(());
}
Err(super::Error::FailedCheck("tsc command failed"))
Err(super::Error::FailedCheck("tsc"))
}
Err(error) => Err(super::Error::Generic(format!("tsc command failed: {error:?}"))),
}
Expand All @@ -112,7 +112,7 @@ pub(super) fn es_check(outdir: &Path, librustdoc_path: &Path) -> Result<(), supe
if exit_status.success() {
return Ok(());
}
Err(super::Error::FailedCheck("es-check command failed"))
Err(super::Error::FailedCheck("es-check"))
}
Err(error) => Err(super::Error::Generic(format!("es-check command failed: {error:?}"))),
}
Expand Down
Loading