Skip to content

Run tests with GCC backend #146414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Run tests with GCC backend #146414

wants to merge 2 commits into from

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 10, 2025
@GuillaumeGomez GuillaumeGomez changed the title Run rust tests with GCC backend Run tests with GCC backend Sep 10, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 10, 2025
Merged
@Kobzol
Copy link
Member

Kobzol commented Sep 10, 2025

We can also specify the doc_url of the job (

rust/src/ci/github-actions/jobs.yml

Line 345 in 5d41f7c

doc_url: https://rustc-dev-guide.rust-lang.org/tests/rust-for-linux.html
) to this: https://rustc-dev-guide.rust-lang.org/tests/codegen-backend-tests/cg_gcc.html

@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from e2d0466 to 2c2dac0 Compare September 10, 2025 16:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch 2 times, most recently from dfd72e4 to bbdbe70 Compare September 10, 2025 17:53
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch 2 times, most recently from 6bcf347 to 3a3bcf7 Compare September 10, 2025 18:24
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 3a3bcf7 to 0efa10e Compare September 10, 2025 19:32
@GuillaumeGomez
Copy link
Member Author

Error in ui tests:

2025-09-10T20:29:55.1757480Z -	error: couldn't load codegen backend /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_gcc-1.91.0-nightly.so: libgccjit.so.0: cannot open shared object file: No such file or directory
2025-09-10T20:29:55.1758929Z +	error: couldn't load codegen backend $BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_gcc-1.91.0-nightly.so: libgccjit.so.0: cannot open shared object file: No such file or directory

Seems like something went wrong with the build/install of libgccjit. Any idea @Kobzol? I thought libgccjit was built with bootstrap if download-ci-gcc was set to false but maybe I misunderstood something.

@tgross35
Copy link
Contributor

Is the .so actually in the load path? For some reason the GCC backend works differently than clif for me locally and I often find I need to manually append LD_LIBRARY_PATH, wonder if it could be something similar here.

@GuillaumeGomez
Copy link
Member Author

Arf, it's the usual case of "it works locally for me". :-/

Gonna try to investigate if it's something wrong with paths.

@GuillaumeGomez
Copy link
Member Author

Seems like we don't copy the .so files when we build gcc unlike when we download it.

@Kobzol Kobzol mentioned this pull request Sep 11, 2025
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
@Zalathar
Rollup merge of rust-lang#146449 - Kobzol:gcc-fix-symlink, r=Guillaum…
bfc33ef 
…eGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang#146414.

r? `@GuillaumeGomez`
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
@Zalathar
Rollup merge of rust-lang#146449 - Kobzol:gcc-fix-symlink, r=Guillaum…
9ff3ffc 
…eGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang#146414.

r? ``@GuillaumeGomez``
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
@Zalathar
Rollup merge of rust-lang#146449 - Kobzol:gcc-fix-symlink, r=Guillaum…
accb4a3 
…eGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang#146414.

r? ```@GuillaumeGomez```
rust-timer added a commit that referenced this pull request Sep 12, 2025
@rust-timer
Unrolled build for #146449
e5ef98e 
Rollup merge of #146449 - Kobzol:gcc-fix-symlink, r=GuillaumeGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks #146414.

r? ```@GuillaumeGomez```
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 0efa10e to 7d861fe Compare September 12, 2025 16:01
@rustbot

This comment has been minimized.

Sign in to view
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 13, 2025
@Zalathar
Rollup merge of #146449 - Kobzol:gcc-fix-symlink, r=GuillaumeGomez
cb548d7 
Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang/rust#146414.

r? ```@GuillaumeGomez```
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 16, 2025
Merged
@antoyo antoyo mentioned this pull request Sep 16, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#146618 - GuillaumeGomez:backend-run-llvm-op…
cf03552 
…tions, r=kobzol

Do not run ui test if options specific to LLVM are used when another codegen backend is used

Based on errors in rust-lang#146414, some tests with LLVM-specific options are run when another codegen is actually the one used.

This PR ignores these tests in such cases now to prevent this situation.

r? `@kobzol`
rust-timer added a commit that referenced this pull request Sep 17, 2025
@rust-timer
Unrolled build for #146618
e25cba0 
Rollup merge of #146618 - GuillaumeGomez:backend-run-llvm-options, r=kobzol

Do not run ui test if options specific to LLVM are used when another codegen backend is used

Based on errors in #146414, some tests with LLVM-specific options are run when another codegen is actually the one used.

This PR ignores these tests in such cases now to prevent this situation.

r? `@kobzol`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 19, 2025
Merged
bors added a commit that referenced this pull request Sep 21, 2025
@bors
Auto merge of #146779 - GuillaumeGomez:gcc-ignore-test_ui_abi, r=Kobz…
1d23da6 
…ol,jieyouxu

Ignore tests in `tests/ui/abi` for the GCC backend

Needed for #146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block #146414.

r? `@Kobzol`
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 7d861fe to 572c8f7 Compare September 21, 2025 20:29
@rustbot

This comment has been minimized.

Sign in to view
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Sep 22, 2025
@bors
Auto merge of #146779 - GuillaumeGomez:gcc-ignore-test_ui_abi, r=Kobz…
3bc8ce1 
…ol,jieyouxu

Ignore tests in `tests/ui/abi` for the GCC backend

Needed for rust-lang/rust#146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block rust-lang/rust#146414.

r? `@Kobzol`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146779 - GuillaumeGomez:gcc-ignore-test_ui_abi, r=Kobz…
4b28357 
…ol,jieyouxu

Ignore tests in `tests/ui/abi` for the GCC backend

Needed for rust-lang/rust#146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block rust-lang/rust#146414.

r? `@Kobzol`
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@bors @Muscraft
Auto merge of rust-lang#146779 - GuillaumeGomez:gcc-ignore-test_ui_ab…
9cb9722 
…i, r=Kobzol,jieyouxu

Ignore tests in `tests/ui/abi` for the GCC backend

Needed for rust-lang#146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block rust-lang#146414.

r? `@Kobzol`
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Sep 25, 2025
@bors
Auto merge of #146779 - GuillaumeGomez:gcc-ignore-test_ui_abi, r=Kobz…
9d66830 
…ol,jieyouxu

Ignore tests in `tests/ui/abi` for the GCC backend

Needed for rust-lang/rust#146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block rust-lang/rust#146414.

r? `@Kobzol`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 26, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#147058 - GuillaumeGomez:ignore-more-ui-test…
69a3cac 
…s, r=Kobzol

Ignore more failing ui tests for GCC backend

Needed for rust-lang#146414.

r? `@Kobzol`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#147058 - GuillaumeGomez:ignore-more-ui-test…
a91918f 
…s, r=Kobzol

Ignore more failing ui tests for GCC backend

Needed for rust-lang#146414.

r? ``@Kobzol``
rust-timer added a commit that referenced this pull request Sep 27, 2025
@rust-timer
Unrolled build for #147058
39d875a 
Rollup merge of #147058 - GuillaumeGomez:ignore-more-ui-tests, r=Kobzol

Ignore more failing ui tests for GCC backend

Needed for #146414.

r? ``@Kobzol``
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 572c8f7 to 35fbb59 Compare September 27, 2025 09:29
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Kobzol
Kobzol reviewed Sep 27, 2025
View reviewed changes
src/ci/docker/host-x86_64/x86_64-gnu-gcc/Dockerfile
--stage 2 \
test \
--test-codegen-backend gcc \
--set 'rust.codegen-backends=[\"llvm\",\"gcc\"]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the second --set isn't needed, because the configure step should produce a bootstrap.toml file that will already have the codegen-backends configured properly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well at least it's explicitly set and in case something changes, we'll know right away when that fails.

github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Sep 29, 2025
@matthiaskrgr
Rollup merge of #147058 - GuillaumeGomez:ignore-more-ui-tests, r=Kobzol
57c297a 
Ignore more failing ui tests for GCC backend

Needed for rust-lang/rust#146414.

r? ``@Kobzol``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @Kobzol @rust-log-analyzer @tgross35 @rustbot