Display ?Sized, const, and lifetime parameters in trait item suggestions across a crate boundary #146442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
BoxyUwU
reviewed
Sep 12, 2025
There was a problem hiding this comment.
late bound lifetimes seem... very difficult to implement here, and also somewhat interesting because we don't actually require the set of late bound lifetimes on the impl to exactly match the set on the trait definition. so I think it doesn't make sense to list them 🤔
Qelxiros
force-pushed
the
trait-suggestion-generics
branch
from
f336c23 to
8e09acd
Compare
BoxyUwU
reviewed
Sep 16, 2025
BoxyUwU
added
S-waiting-on-author
Qelxiros
force-pushed
the
trait-suggestion-generics
branch
from
8e09acd to
1a15108
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup of 5 pull requests Successful merges: - #146442 (Display ?Sized, const, and lifetime parameters in trait item suggestions across a crate boundary) - #146474 (Improve `core::ascii` coverage) - #146605 (Bump rustfix 0.8.1 -> 0.8.7) - #146611 (bootstrap: emit hint if a config key is used in the wrong section) - #146618 (Do not run ui test if options specific to LLVM are used when another codegen backend is used) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 17, 2025
Rollup merge of #146442 - Qelxiros:trait-suggestion-generics, r=BoxyUwU Display ?Sized, const, and lifetime parameters in trait item suggestions across a crate boundary context: #145929 This fixes the MetaSized issue and adds const generics and early bound lifetimes. Late bound lifetimes are harder because they aren't returned by `generics_of`. I'm going to look into it, but there's no guarantee I'll be successful. Fixes #146404. r? `@BoxyUwu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #145929
This fixes the MetaSized issue and adds const generics and early bound lifetimes. Late bound lifetimes are harder because they aren't returned by
generics_of. I'm going to look into it, but there's no guarantee I'll be successful.Fixes #146404.
r? @BoxyUwU