Make PeekMut generic over the allocator
#146621
Open
+51
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
joboet
requested changes
Sep 18, 2025
|
r? libs-api |
rustbot
added
the
T-libs-api
joboet
changed the title
Vec::peek_mutPeekMut generic over the allocator
cammeresi
force-pushed
the
peek-20250915
branch
from
c2c526d to
7dd447e
Compare
joboet
reviewed
Sep 18, 2025
This comment has been minimized.
This comment has been minimized.
cammeresi
force-pushed
the
peek-20250915
branch
from
7dd447e to
cc0a3d4
Compare
joboet
approved these changes
Sep 18, 2025
|
@rust-lang/libs-api anybody willing to give a quick thumbs up here? Straightforward extension to unstable API. @cammeresi please squash when you get the chance |
Amanieu
reviewed
Sep 19, 2025
library/alloc/src/vec/peek_mut.rs
Outdated
| #[unstable(feature = "vec_peek_mut", issue = "122742")] | ||
| pub struct PeekMut<'a, T> { | ||
| vec: &'a mut Vec<T>, | ||
| pub struct PeekMut<'a, T, A: Allocator> { |
There was a problem hiding this comment.
The allocator parameter should be unstable and default to Global, just like that of Vec,
There was a problem hiding this comment.
Thanks, I was going to ask. I wasn't sure since there's no public entry point by which to create one directly. I guess the point is to be defensive against such an accidental change?
Does that mean that std::collections::btree_map::IntoKeys is incorrectly missing the attribute?
|
r=me once the generic parameter is fixed. |
cammeresi
force-pushed
the
peek-20250915
branch
from
cc0a3d4 to
934ee04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #122742