Port `feature` to the new attribute system #146652

jdonszelmann · 2025-09-16T19:31:32Z

No description provided.

jdonszelmann · 2025-09-16T19:32:17Z

tests/ui/feature-gates/gated-bad-feature.stderr

+error[E0565]: malformed `feature` attribute input
+  --> $DIR/gated-bad-feature.rs:1:1
+   |
+LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]


working on a PR to re-improve these diagnostics (but for all attrs)

#146653 and #146658

bors · 2025-09-17T12:10:49Z

☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-09-18T04:55:51Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GuillaumeGomez

Error code changes look good to me. Letting the rest of the review to the reviewer. :)

View changes since this review

fee1-dead · 2025-09-19T22:24:19Z

r? compiler

compiler/rustc_expand/src/config.rs

nnethercote · 2025-09-20T04:59:50Z

r=me with the naming issue fixed.

@bors delegate=jdonszelmann

jdonszelmann · 2025-09-22T04:39:58Z

thanks nicholas! that's a fair point

@bors r=nnethercote

bors · 2025-09-22T04:40:01Z

📌 Commit 858e26c has been approved by nnethercote

It is now in the queue for this repository.

jdonszelmann · 2025-09-22T04:40:05Z

@bors rollup

…parser, r=nnethercote Port `feature` to the new attribute system

Rollup of 10 pull requests Successful merges: - #145411 (regression test for Cow<[u8]> layout) - #146317 (Add panic=immediate-abort) - #146397 (std_detect on Darwin AArch64: update features) - #146594 (bootstrap: Don't force -static for musl targets in cc-rs) - #146652 (Port `feature` to the new attribute system) - #146791 (emit attribute for readonly non-pure inline assembly) - #146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly) - #146838 (Introduce "wrapper" helpers to rustdoc) - #146846 (btree InternalNode::new safety comments) - #146858 (Make mips64el-unknown-linux-muslabi64 link dynamically) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-09-22T06:14:10Z

Failed in rollup: #146873 (comment)

@bors r-

bors · 2025-09-25T18:41:37Z

☔ The latest upstream changes (presumably #147019) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-09-28T13:30:14Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2025-09-28T13:39:00Z

#clippy > broken lint: `undocumented_unsafe_blocks` @ 💬

jdonszelmann · 2025-09-28T13:39:13Z

@rustbot blocked

rust-log-analyzer · 2025-09-28T13:43:13Z

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_attr_parsing v0.0.0 (/checkout/compiler/rustc_attr_parsing)
error: unused import: `LimitInvalid`
 --> compiler/rustc_attr_parsing/src/attributes/crate_level.rs:2:61
  |
2 | use crate::session_diagnostics::{FeatureExpectedSingleWord, LimitInvalid};
  |                                                             ^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

…nethercote improve diagnostics for empty attributes Adds a note about them not having any effect. This was previously done for `feature` attributes but no other attributes. In [converting the `feature` parser](rust-lang#146652) I removed that note. This PR adds it back in and makes it so all attributes benefit from it. Not blocked on rust-lang#146652, either can merge first

Rollup merge of #146653 - jdonszelmann:empty-attr-diags, r=nnethercote improve diagnostics for empty attributes Adds a note about them not having any effect. This was previously done for `feature` attributes but no other attributes. In [converting the `feature` parser](#146652) I removed that note. This PR adds it back in and makes it so all attributes benefit from it. Not blocked on #146652, either can merge first

jdonszelmann commented Sep 16, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the convert-feature-attr-parser branch from 6b9fb75 to e57b585 Compare September 16, 2025 19:47

jdonszelmann mentioned this pull request Sep 16, 2025

improve diagnostics for empty attributes #146653

Merged

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the convert-feature-attr-parser branch from e57b585 to bd9995e Compare September 16, 2025 21:25

This comment has been minimized.

Sign in to view

jdonszelmann mentioned this pull request Sep 16, 2025

Better argument diagnostics in attributes #146658

Draft

jdonszelmann force-pushed the convert-feature-attr-parser branch from bd9995e to 365b5ea Compare September 16, 2025 22:27

jdonszelmann force-pushed the convert-feature-attr-parser branch from 365b5ea to 950ea0b Compare September 18, 2025 00:56

jdonszelmann marked this pull request as ready for review September 18, 2025 04:55

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2025

This comment was marked as resolved.

Sign in to view

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 18, 2025

rustbot assigned fee1-dead Sep 18, 2025

jdonszelmann force-pushed the convert-feature-attr-parser branch from 950ea0b to bceec5b Compare September 18, 2025 05:06

This was referenced Sep 18, 2025

Port #[register_tool] to the new attribute system #146702

Draft

Tracking issue: Attribute refactor #131229

Open

GuillaumeGomez approved these changes Sep 19, 2025

View reviewed changes

rustbot assigned nnethercote and unassigned fee1-dead Sep 19, 2025

nnethercote approved these changes Sep 20, 2025

View reviewed changes

compiler/rustc_expand/src/config.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the convert-feature-attr-parser branch from bceec5b to 802d92a Compare September 22, 2025 04:21

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the convert-feature-attr-parser branch from 802d92a to 858e26c Compare September 22, 2025 04:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 22, 2025

Rollup merge of rust-lang#146652 - jdonszelmann:convert-feature-attr-…

ce358ff

…parser, r=nnethercote Port `feature` to the new attribute system

Zalathar mentioned this pull request Sep 22, 2025

Rollup of 10 pull requests #146873

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2025

jdonszelmann force-pushed the convert-feature-attr-parser branch from 858e26c to 024ed3c Compare September 27, 2025 15:27

This comment has been minimized.

Sign in to view

jdonszelmann added 2 commits September 28, 2025 15:29

port #[feature] to the new attribute parsing infrastructure

7ad49e9

use feature parser throughout the compiler

3d628f0

jdonszelmann force-pushed the convert-feature-attr-parser branch from 024ed3c to 3d628f0 Compare September 28, 2025 13:30

jdonszelmann mentioned this pull request Sep 28, 2025

fix bug in proc macro derive diagnostics #146657

Open

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2025

Port feature to the new attribute system #146652

Are you sure you want to change the base?

Port feature to the new attribute system #146652

Uh oh!

Conversation

jdonszelmann commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Sep 17, 2025

Uh oh!

This comment was marked as resolved.

rustbot commented Sep 18, 2025

Uh oh!

GuillaumeGomez left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fee1-dead commented Sep 19, 2025

Uh oh!

Uh oh!

nnethercote commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

jdonszelmann commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

jdonszelmann commented Sep 22, 2025

Uh oh!

Zalathar commented Sep 22, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 28, 2025

Uh oh!

jdonszelmann commented Sep 28, 2025

Uh oh!

jdonszelmann commented Sep 28, 2025

Uh oh!

rust-log-analyzer commented Sep 28, 2025

Uh oh!

Uh oh!

Port `feature` to the new attribute system #146652

Port `feature` to the new attribute system #146652

jdonszelmann commented Sep 16, 2025 •

edited

Loading

GuillaumeGomez left a comment •

edited by rustbot

Loading

nnethercote commented Sep 20, 2025 •

edited

Loading