Rollup of 6 pull requests #146946

matthiaskrgr · 2025-09-23T21:40:31Z

Successful merges:

constify {float}::total_cmp() #146818 (constify {float}::total_cmp())
rustc-dev-guide subtree update #146896 (rustc-dev-guide subtree update)
Update books #146898 (Update books)
Fix a crash/mislex when more than one frontmatter closing possibility is considered #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn #146904 (Tracking Issue for {Mutex, RwLock, ReentrantLock}::data_ptr #140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
add regression test for issue 146537 #146907 (add regression test for issue 146537)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

I can guess what this meant, but decided to just keep it simple

split overlong sentences

…en-url Fix broken Microsoft URL missing slash

Co-authored-by: Tshepang Mbambo <[email protected]>

glossary: add entry for rustbuild

documentation for Enzyme Type Trees

Rename "crashes tests" to "crash tests"

remove confusing parts of sentence

Co-authored-by: Ralf Jung <[email protected]>

Clarify that backtick escaping doesn't work for `@bors try jobs`

a valid state is achieved by passing the test suite

about-this-guide.md: improve a bit

…sing-docs Add missing documentation for running tests with GCC backend

point to Compiler team docs on Forge

Correct a misspelling of RUSTC_LOG

This updates the rust-version file to 9f32ccf.

matthiaskrgr · 2025-09-23T21:40:55Z

@bors r+ rollup=never p=5

bors · 2025-09-23T21:40:57Z

📌 Commit 6617536 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-09-24T00:42:37Z

⌛ Testing commit 6617536 with merge 2b403c4...

Rollup of 6 pull requests Successful merges: - #146818 (constify {float}::total_cmp()) - #146896 (rustc-dev-guide subtree update) - #146898 (Update books) - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered) - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn) - #146907 (add regression test for issue 146537) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-24T04:24:20Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-09-24T04:35:23Z

@bors retry

bors · 2025-09-24T09:26:08Z

⌛ Testing commit 6617536 with merge 4b9e564...

Rollup of 6 pull requests Successful merges: - #146818 (constify {float}::total_cmp()) - #146896 (rustc-dev-guide subtree update) - #146898 (Update books) - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered) - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn) - #146907 (add regression test for issue 146537) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-09-24T09:53:43Z

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
error: failed to get `rustversion` as a dependency of package `term v0.7.0`
    ... which satisfies dependency `term = "^0.7"` (locked to 0.7.0) of package `rustfmt-nightly v1.8.0 (/checkout/src/tools/rustfmt)`

Caused by:
  download of ru/st/rustversion failed

Caused by:
  failed to download from `https://index.crates.io/ru/st/rustversion`

Caused by:
  [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Bootstrap failed while executing `dist --host= --target x86_64-unknown-fuchsia,aarch64-unknown-fuchsia,wasm32-unknown-unknown,wasm32-wasip1,wasm32-wasip1-threads,wasm32-wasip2,wasm32v1-none,x86_64-unknown-linux-gnux32,x86_64-fortanix-unknown-sgx,nvptx64-nvidia-cuda,armv7-unknown-linux-gnueabi,armv7-unknown-linux-musleabi,i686-unknown-freebsd,x86_64-unknown-none,aarch64-unknown-uefi,i686-unknown-uefi,x86_64-unknown-uefi,riscv64gc-unknown-linux-musl`
Build completed unsuccessfully in 0:11:47

matthiaskrgr · 2025-09-24T09:54:13Z

@bors retry

bors · 2025-09-24T09:55:24Z

⌛ Testing commit 6617536 with merge e9385f9...

bors · 2025-09-24T13:03:45Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e9385f9 to master...

rust-timer · 2025-09-24T13:05:34Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146818	constify {float}::total_cmp()	`9b77832b24ff443e952b9d33cb29b7b02a26f931` (link)
#146896	rustc-dev-guide subtree update	`110989f30b5b2430c50952bc8e028e50ea1a5a43` (link)
#146898	Update books	`a967e7c063729f3d560575a3699bc173d701e17c` (link)
#146899	Fix a crash/mislex when more than one frontmatter closing p…	`20e53c9eee9bbb6e84cc74949b2351c6864c585c` (link)
#146904	#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn	`5e1b33550cfbe38f4c5d2654818f68606a3898b0` (link)
#146907	add regression test for issue 146537	`f64b573872a3020182fc7534eee77df4f67107de` (link)

previous master: 3e887f5faa

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-24T13:06:33Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3e887f5 (parent) -> e9385f9 (this PR)

Test differences

Show 275 test diffs

Stage 1

floats::total_cmp::const_::test_f128: [missing] -> pass (J1)
floats::total_cmp::const_::test_f16: [missing] -> pass (J1)
floats::total_cmp::const_::test_f32: [missing] -> pass (J1)
floats::total_cmp::const_::test_f64: [missing] -> pass (J1)
[ui] tests/ui/frontmatter/unclosed-6.rs: [missing] -> pass (J3)
[ui] tests/ui/suggestions/non_copy_move_out_of_tuple.rs: [missing] -> pass (J3)

Stage 2

floats::total_cmp::const_::test_f128: [missing] -> pass (J0)
floats::total_cmp::const_::test_f16: [missing] -> pass (J0)
floats::total_cmp::const_::test_f32: [missing] -> pass (J0)
floats::total_cmp::const_::test_f64: [missing] -> pass (J0)
[ui] tests/ui/frontmatter/unclosed-6.rs: [missing] -> pass (J2)
[ui] tests/ui/suggestions/non_copy_move_out_of_tuple.rs: [missing] -> pass (J2)
[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend (we want LLVM/LLD to be built with zstd support)) -> pass (J4)

Additionally, 262 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e9385f9eea0221ef295a188d49d16f8f5189abf1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-arm-linux-musl: 16901.5s -> 5603.2s (-66.8%)
pr-check-1: 4374.7s -> 1474.0s (-66.3%)
dist-x86_64-solaris: 15388.6s -> 5262.0s (-65.8%)
dist-sparcv9-solaris: 14014.7s -> 5258.6s (-62.5%)
dist-x86_64-illumos: 16672.8s -> 6278.7s (-62.3%)
pr-check-2: 5277.3s -> 2180.3s (-58.7%)
x86_64-rust-for-linux: 6130.7s -> 2549.1s (-58.4%)
dist-android: 3651.2s -> 1536.2s (-57.9%)
dist-x86_64-freebsd: 11319.8s -> 5041.3s (-55.5%)
dist-ohos-x86_64: 9669.8s -> 4307.2s (-55.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-24T14:13:39Z

Finished benchmarking commit (e9385f9): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-2.0%, 3.7%]	2

Cycles

Results (secondary 3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.082s -> 471.559s (0.10%)
Artifact size: 387.87 MiB -> 387.91 MiB (0.01%)

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#146818 (constify {float}::total_cmp()) - rust-lang#146896 (rustc-dev-guide subtree update) - rust-lang#146898 (Update books) - rust-lang#146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered) - rust-lang#146904 (rust-lang#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn) - rust-lang#146907 (add regression test for issue 146537) r? `@ghost` `@rustbot` modify labels: rollup

tshepang and others added 30 commits September 6, 2025 06:26

point to Compiler team docs on Forge

0dc233f

remove confusing parts of sentence

1806a82

I can guess what this meant, but decided to just keep it simple

sembr

755db7f

fix markup

cb0e26f

readability

94da520

Merge pull request rust-lang#2585 from rust-lang/tshepang/sembr

8c324de

split overlong sentences

Fix broken Microsoft URL missing slash

a5575f8

Merge pull request rust-lang#2586 from ali90h/fix-microsoft-link-brok…

808595e

…en-url Fix broken Microsoft URL missing slash

glossary: add entry for rustbuild

096ae06

glossary(rustbuild): reword according to code review

196b49a

Co-authored-by: Tshepang Mbambo <[email protected]>

Add missing documentation for running tests with GCC backend

82ff002

Merge pull request rust-lang#2516 from lolbinarycat/patch-4

76c4d68

glossary: add entry for rustbuild

docs: typetree in autodiff

d8f0842

Merge pull request rust-lang#2385 from KMJ-007/master

ff59107

documentation for Enzyme Type Trees

Restructure the docs

d588c11

Rename "crashes tests" to "crash tests"

7a4b728

Merge pull request rust-lang#2588 from fmease/to-crash-tests

ddfd47a

Rename "crashes tests" to "crash tests"

Merge pull request rust-lang#2584 from rust-lang/tshepang-patch-5

ee63b07

remove confusing parts of sentence

Clarify that backtick escaping doesn't work for @bors try jobs

7b0b0bb

Update src/tests/ci.md

001f8e3

Co-authored-by: Ralf Jung <[email protected]>

Merge pull request rust-lang#2589 from Kobzol/ci-bors-backticks

3a14fb7

Clarify that backtick escaping doesn't work for `@bors try jobs`

a valid state is achieved by passing the test suite

ee496f2

Merge pull request rust-lang#2591 from rust-lang/tshepang-patch-5

cea82e3

a valid state is achieved by passing the test suite

about-this-guide.md: improve a bit

b17213a

Merge pull request rust-lang#2592 from rust-lang/tshepang-patch-5

66a84ef

about-this-guide.md: improve a bit

Merge pull request rust-lang#2587 from GuillaumeGomez/gcc-backend-mis…

9819cea

…sing-docs Add missing documentation for running tests with GCC backend

Merge pull request rust-lang#2580 from rust-lang/tshepang-patch-2

72b0291

point to Compiler team docs on Forge

Correct a misspelling of RUSTC_LOG

d887c57

Merge pull request rust-lang#2594 from cammeresi/spelling-20250921

a11333a

Correct a misspelling of RUSTC_LOG

Prepare for merging from rust-lang/rust

5658b39

This updates the rust-version file to 9f32ccf.

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 23, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 24, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2025

Zalathar mentioned this pull request Sep 24, 2025

Rollup of 14 pull requests #146966

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2025

bors merged commit e9385f9 into rust-lang:master Sep 24, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 24, 2025

bors mentioned this pull request Sep 24, 2025

f16_f128: enable some more tests in Miri #146737

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #146946

Rollup of 6 pull requests #146946

Uh oh!

matthiaskrgr commented Sep 23, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Sep 23, 2025

Uh oh!

bors commented Sep 23, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

rust-log-analyzer commented Sep 24, 2025

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 24, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #146946

Rollup of 6 pull requests #146946

Uh oh!

Conversation

matthiaskrgr commented Sep 23, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Sep 23, 2025

Uh oh!

bors commented Sep 23, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

rust-log-analyzer commented Sep 24, 2025

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 24, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Sep 23, 2025 •

edited by rustbot

Loading