Rollup of 7 pull requests #147003

matthiaskrgr · 2025-09-24T21:33:30Z

Successful merges:

Fix duration_since panic on unix when std is built with integer overflow checks #146556 (Fix duration_since panic on unix when std is built with integer overflow checks)
Clarify Display for error should not include source #146679 (Clarify Display for error should not include source)
Improve the pretty print of UnstableFeature clause #146753 (Improve the pretty print of UnstableFeature clause)
Improve derive suggestion of const param #146894 (Improve derive suggestion of const param)
core: simplify CStr::default() #146950 (core: simplify CStr::default())
Fix infinite recursion in Path::eq with String #146958 (Fix infinite recursion in Path::eq with String)
fix ICE in writeback due to bound regions #146971 (fix ICE in writeback due to bound regions)

r? @ghost
@rustbot modify labels: rollup

Just use a `CStr`-literal...

Make the suggestion not to remove the adt and use the name of the adt variant

Fix duration_since panic on unix when std is built with integer overflow checks Add a test for regression rust-lang#146228, and turns out this test fails detects error when std is compiled with integer overflow checks. Original regression was reverted in rust-lang#146473. First attempt to fix was in rust-lang#146247; test and some code is copied from there, thanks `@eval-exec` r? `@RalfJung`

…=dtolnay Clarify Display for error should not include source Fixes rust-lang#145561. r? `@Noratrieb`

…e, r=BoxyUwU Improve the pretty print of UnstableFeature clause As per rust-lang#145095 (comment), we could make the diagnostic for unsatisfiable ``UnstableFeature`` clause better. r? `@BoxyUwU`

Improve derive suggestion of const param Make the suggestion not to remove the adt and use the name of the adt variant in the diagnostic. r? `@BoxyUwU`

core: simplify `CStr::default()` Just use a `CStr`-literal...

…r=joboet Fix infinite recursion in Path::eq with String - Closes [after beta backport] rust-lang#146940

fix ICE in writeback due to bound regions fixes rust-lang#117808 r? `@BoxyUwU`

matthiaskrgr · 2025-09-24T21:47:47Z

@bors r+ rollup=never p=5

bors · 2025-09-24T21:47:50Z

📌 Commit 57ee169 has been approved by matthiaskrgr

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - #146556 (Fix duration_since panic on unix when std is built with integer overflow checks) - #146679 (Clarify Display for error should not include source) - #146753 (Improve the pretty print of UnstableFeature clause) - #146894 (Improve derive suggestion of const param) - #146950 (core: simplify `CStr::default()`) - #146958 (Fix infinite recursion in Path::eq with String) - #146971 (fix ICE in writeback due to bound regions) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-24T21:57:09Z

⌛ Testing commit 57ee169 with merge 8565a0e...

bors · 2025-09-25T00:04:19Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-09-25T03:08:35Z

@bors retry

bors · 2025-09-25T10:30:55Z

⌛ Testing commit 57ee169 with merge 7cfd7d3...

bors · 2025-09-25T13:47:38Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7cfd7d3 to master...

rust-timer · 2025-09-25T13:49:41Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146556	Fix duration_since panic on unix when std is built with int…	`5bc82927efca545be1de3ef4fbdc31bcdc402ab0` (link)
#146679	Clarify Display for error should not include source	`3e72d6391e5b27fb9c7f0bf1d4a1d82abaab3379` (link)
#146753	Improve the pretty print of UnstableFeature clause	`fa2bdbd265d65c398bd14d31b4bb09b8c58b65ee` (link)
#146894	Improve derive suggestion of const param	`a8466153f6ac76186bca61de4f5313bd35471161` (link)
#146950	core: simplify `CStr::default()`	`b8c488ec53936e3ebd626762b03d92cb8dbdc6cf` (link)
#146958	Fix infinite recursion in Path::eq with String	`6a04b07414f33d48389a8ab299e4eac9867f3030` (link)
#146971	fix ICE in writeback due to bound regions	`1ce61cb576ed6b0b8408443fd0243dfbdf02e98f` (link)

previous master: bbcbc7818b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-25T13:50:24Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bbcbc78 (parent) -> 7cfd7d3 (this PR)

Test differences

Show 155 test diffs

Stage 1

[crashes] tests/crashes/117808.rs: pass -> [missing] (J1)
[ui] tests/ui/traits/next-solver/writeback-predicate-bound-region.rs: [missing] -> pass (J1)
compare_path_like_to_str_like: [missing] -> pass (J3)
compare_path_to_str: pass -> [missing] (J3)
system_time_duration_since_max_range_on_unix: [missing] -> pass (J3)

Stage 2

compare_path_like_to_str_like: [missing] -> pass (J0)
compare_path_to_str: pass -> [missing] (J0)
system_time_duration_since_max_range_on_unix: [missing] -> pass (J2)
[crashes] tests/crashes/117808.rs: pass -> [missing] (J4)
[ui] tests/ui/traits/next-solver/writeback-predicate-bound-region.rs: [missing] -> pass (J5)
[crashes] tests/crashes/117808.rs: ignore (ignored if rustc wasn't built with debug assertions) -> [missing] (J6)

Additionally, 144 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7cfd7d328b14b936c7ffede92cacebe8557c6388 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 6412.1s -> 9124.5s (42.3%)
aarch64-apple: 5315.6s -> 6382.7s (20.1%)
dist-aarch64-windows-gnullvm: 4604.1s -> 5178.9s (12.5%)
dist-x86_64-apple: 8598.5s -> 7563.4s (-12.0%)
dist-apple-various: 4308.6s -> 4824.4s (12.0%)
dist-powerpc64le-linux-musl: 5564.2s -> 5089.5s (-8.5%)
armhf-gnu: 4832.6s -> 5239.8s (8.4%)
aarch64-gnu-llvm-20-1: 3516.9s -> 3738.1s (6.3%)
tidy: 170.1s -> 180.7s (6.2%)
test-various: 4850.0s -> 4558.4s (-6.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-25T14:58:48Z

Finished benchmarking commit (7cfd7d3): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.8%, 1.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-2.5%, -0.7%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.2%, 3.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.723s -> 469.935s (-0.17%)
Artifact size: 388.07 MiB -> 388.04 MiB (-0.01%)

Mark-Simulacrum · 2025-09-29T01:35:45Z

Bimodality, not real regression.

joboet and others added 16 commits September 24, 2025 00:50

core: simplify CStr::default()

aa53782

Just use a `CStr`-literal...

allow bound regions in writeback

32d24f9

imrpove type_op failure ICE

2886ca4

alloc: simplify Default for Box<CStr> and Rc<CStr>

a875f77

Improve derive suggestion of const param

3028935

Make the suggestion not to remove the adt and use the name of the adt variant

Fix infinite recursion in Path::eq with String

5a4e536

Improve the pretty print of UnstableFeature clause

4e62715

Clarify Display for error should not include source

a9554b4

Repro duration_since regression from issue 146228

92859e9

Rollup merge of rust-lang#146679 - stepancheg:error-display-source, r…

0ab9386

…=dtolnay Clarify Display for error should not include source Fixes rust-lang#145561. r? `@Noratrieb`

Rollup merge of rust-lang#146753 - tiif:unsatisfiable-unstable-featur…

7a4ac48

…e, r=BoxyUwU Improve the pretty print of UnstableFeature clause As per rust-lang#145095 (comment), we could make the diagnostic for unsatisfiable ``UnstableFeature`` clause better. r? `@BoxyUwU`

Rollup merge of rust-lang#146894 - tiif:suggest_feature_attr, r=BoxyUwU

6351a63

Improve derive suggestion of const param Make the suggestion not to remove the adt and use the name of the adt variant in the diagnostic. r? `@BoxyUwU`

Rollup merge of rust-lang#146950 - joboet:cstr_default, r=tgross35

6618ac7

core: simplify `CStr::default()` Just use a `CStr`-literal...

Rollup merge of rust-lang#146958 - el-ev:fix_path_string_eq_recurse, …

d10d6bf

…r=joboet Fix infinite recursion in Path::eq with String - Closes [after beta backport] rust-lang#146940

Rollup merge of rust-lang#146971 - lcnr:fix-writeback, r=BoxyUwU

57ee169

fix ICE in writeback due to bound regions fixes rust-lang#117808 r? `@BoxyUwU`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 25, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025

Zalathar mentioned this pull request Sep 25, 2025

Rollup of 14 pull requests #147019

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2025

bors merged commit 7cfd7d3 into rust-lang:master Sep 25, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 25, 2025

rustbot added the perf-regression Performance regression. label Sep 25, 2025

Mark-Simulacrum removed the perf-regression Performance regression. label Sep 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #147003

Rollup of 7 pull requests #147003

Uh oh!

matthiaskrgr commented Sep 24, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

matthiaskrgr commented Sep 25, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 25, 2025

Uh oh!

Mark-Simulacrum commented Sep 29, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #147003

Rollup of 7 pull requests #147003

Uh oh!

Conversation

matthiaskrgr commented Sep 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

matthiaskrgr commented Sep 25, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 25, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Mark-Simulacrum commented Sep 29, 2025

Uh oh!

Uh oh!

matthiaskrgr commented Sep 24, 2025 •

edited by rustbot

Loading