Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
cee2594
fix: Prevent invalid transformation in 'Replace match with if let' as…
sgasho Aug 26, 2025
4f0e9e2
Fix closure in match not applicable for add_braces
A4-Tacks Sep 2, 2025
1bf57df
Add applicable on bang `!` for apply_demorgan
A4-Tacks Sep 3, 2025
78e0960
Add cfg_attr predicate completion
A4-Tacks Sep 4, 2025
ec34e8e
Fix precedence parenthesis for replace_arith_op
A4-Tacks Sep 4, 2025
603d64c
Fix complete type in nested pattern
A4-Tacks Sep 17, 2025
1a56d27
Fix applicable after l_curly for replace_is_method_with_if_let_method
A4-Tacks Sep 18, 2025
5a043ce
Fix extract_variable on LetExpr
A4-Tacks Sep 19, 2025
024ea02
Fix `else` completion before else keyword
A4-Tacks Sep 19, 2025
3ba0c22
fix: Make flycheck clearing dependency-aware
ShoyuVanilla Sep 17, 2025
bb1ad20
Fix panics on `Foo{mut x}` for destructure_struct_binding
A4-Tacks Sep 20, 2025
8eda71b
Fix panic `!self.data().mutable` for destructure_struct_binding
A4-Tacks Sep 20, 2025
1850a55
Fix unused_variables fixes shorthand record field
A4-Tacks Sep 20, 2025
b6eb085
Merge pull request #20708 from A4-Tacks/destruct-ref-mut-panics
ShoyuVanilla Sep 20, 2025
36b75b5
Merge pull request #20702 from A4-Tacks/else-not-before-else
ShoyuVanilla Sep 20, 2025
f6170ec
Merge pull request #20700 from A4-Tacks/extract-var-let-expr
ShoyuVanilla Sep 20, 2025
e976c9c
Merge pull request #20688 from A4-Tacks/fix-applicable-after-l-curly-…
ShoyuVanilla Sep 20, 2025
19a67eb
Fix selected multi variants applicable generate_default_from_enum_var…
A4-Tacks Sep 18, 2025
d6755e6
Merge pull request #20689 from ShoyuVanilla/accurate-flycheck
davidbarsky Sep 20, 2025
d0da6a1
Merge pull request #20686 from A4-Tacks/gen-default-not-apply-selected
ShoyuVanilla Sep 20, 2025
a08e8ba
Merge pull request #20709 from A4-Tacks/destruct-panic-on-not-add-der…
ShoyuVanilla Sep 20, 2025
edb81ad
Merge pull request #20710 from A4-Tacks/unused-var-shorthand
ShoyuVanilla Sep 20, 2025
71fdb59
Fix IfExpr then branch suggest
A4-Tacks Sep 13, 2025
66b1066
Fix to implements in-place stdx::replace
A4-Tacks Sep 20, 2025
3810e17
Merge pull request #20661 from A4-Tacks/suggest-if-body
ShoyuVanilla Sep 20, 2025
c38c6b8
Add some test for stdx::replace
A4-Tacks Sep 20, 2025
c8182c4
Merge pull request #20706 from A4-Tacks/stdx-replace-inplace
ShoyuVanilla Sep 20, 2025
aa3aac5
allow take union field addresses in safe rust
Kivooeo Sep 20, 2025
1525bf3
Fix not applicable on trailing comma for remove_dbg
A4-Tacks Sep 21, 2025
45dda35
Merge pull request #20714 from A4-Tacks/rm-dbg-trailing-comma
ShoyuVanilla Sep 21, 2025
ab7cfc7
Clarify `rust-analyzer.inlayHints.maxLength` is not a hard guarantee
ChayimFriedman2 Sep 21, 2025
8f1518f
Merge pull request #20718 from ChayimFriedman2/inlay-max-len-docs
ChayimFriedman2 Sep 22, 2025
dc805bf
Fix apply in internal if for pull_assignment_up
A4-Tacks Sep 22, 2025
c5e6682
Fix applicable on underscore for bind_unused_param
A4-Tacks Sep 22, 2025
4193716
Another regression test for next solver fixed bug
ChayimFriedman2 Sep 22, 2025
0600b4d
Merge pull request #20724 from ChayimFriedman2/ns-cleanup3
ChayimFriedman2 Sep 22, 2025
a45d58b
Fix lifetime elision handling for `Fn`-style trait bounds
ChayimFriedman2 Sep 22, 2025
75e3eb8
internal: Migrate more predicate things to next-solver
ShoyuVanilla Sep 21, 2025
a3c39b3
Merge pull request #20717 from ShoyuVanilla/migrate-more
ChayimFriedman2 Sep 22, 2025
27b0aeb
Merge pull request #20725 from ChayimFriedman2/fix-missing-lifetime
ShoyuVanilla Sep 22, 2025
8ee0aa1
Merge pull request #20723 from A4-Tacks/fix-bind-unused-applicable-un…
ShoyuVanilla Sep 22, 2025
44f3de3
Merge pull request #20722 from A4-Tacks/pull-assign-up-inner-if
ShoyuVanilla Sep 22, 2025
06ee0ef
Merge pull request #20679 from A4-Tacks/no-comp-ty-in-nested-pat
ShoyuVanilla Sep 22, 2025
34f0002
Merge pull request #20592 from A4-Tacks/add-braces-closure-in-match
ShoyuVanilla Sep 22, 2025
2ba71fb
Use ns versions of with_diagnostics queries
jackh726 Aug 15, 2025
9e8f6e8
Make Field::ty return TypeNs
jackh726 Aug 17, 2025
263b2a5
Add 'db to TraitEnvironment
jackh726 Sep 11, 2025
06078df
Use ParamEnv in TraitEnvironment
jackh726 Sep 22, 2025
c241ff4
Add const parameter keyword completion
A4-Tacks Sep 23, 2025
2d495cc
Migrate `expand_record_rest_pattern` assist to use `SyntaxEditor`
A4-Tacks Sep 23, 2025
b78f5b3
Merge pull request #20728 from jackh726/next-trait-solver-next2
ShoyuVanilla Sep 23, 2025
1393e63
Merge pull request #20730 from A4-Tacks/migrate-expand-rest-pat
ShoyuVanilla Sep 23, 2025
c960e9c
Remove lower::ty in favor of lower_nextsolver::ty
jackh726 Sep 23, 2025
9e34268
Remove lower::value_ty in favor of lower_nextsolver::value_ty
jackh726 Sep 23, 2025
a025cac
Expose iterators over an inference result's types
regexident Sep 17, 2025
aca4340
Merge pull request #20543 from sgasho/fix/19443_replace_match_with_if…
ShoyuVanilla Sep 23, 2025
489f017
Use lower_nextsolver::callable_item_signature instead of lower::calla…
jackh726 Sep 23, 2025
8337750
Remove all non-ns diagnostics queries, naming consistenly
jackh726 Sep 23, 2025
94bf6b4
Be sure to instantiate and pass up trait refs in named_associated_typ…
jackh726 Sep 23, 2025
affd5c0
Merge pull request #20733 from jackh726/next-trait-solver-next3
ShoyuVanilla Sep 24, 2025
763ef13
Remove non-ns version of impl_self_ty and impl_trait
jackh726 Sep 24, 2025
6e89794
Fix applicable on if-let-chain for invert_if
A4-Tacks Sep 24, 2025
871261a
Merge pull request #20683 from regexident/inference-result-types-iter
ChayimFriedman2 Sep 24, 2025
a3840d9
Implement fallback properly
ChayimFriedman2 Sep 22, 2025
da9831c
Merge pull request #20721 from ChayimFriedman2/fix-never
ChayimFriedman2 Sep 24, 2025
1646027
fix SCIP panicking due to salsa not attaching
itsjunetime Sep 24, 2025
3280c21
Prepare for merging from rust-lang/rust
invalid-email-address Sep 25, 2025
ff7e731
Merge ref 'caccb4d0368b' from rust-lang/rust
invalid-email-address Sep 25, 2025
61792af
Also install rustfmt on stable
lnicola Sep 25, 2025
13d512f
Install cargo for proc-macro-srv tests
lnicola Sep 25, 2025
4a39e59
Merge pull request #20740 from rust-lang/rustc-pull
lnicola Sep 25, 2025
6fdf6b5
Merge pull request #20735 from itsjunetime/fix_scip_salsa
ShoyuVanilla Sep 25, 2025
70d56dd
Merge pull request #20738 from jackh726/next-trait-solver-next4
ShoyuVanilla Sep 25, 2025
a9637ef
Fix fixes for unused raw variables
A4-Tacks Sep 25, 2025
c1cd1da
Add let-chain support for convert_to_guarded_return
A4-Tacks Sep 3, 2025
1947949
Fix not applicable for if-expr in let-stmt
A4-Tacks Sep 25, 2025
11c35cd
Add applicable in closure for convert_to_guarded_return
A4-Tacks Sep 25, 2025
e0f22df
fix transcriber error in declarative macros for negative integer lite…
Sep 25, 2025
79b0a92
Merge pull request #20742 from A4-Tacks/unused-raw-var
ShoyuVanilla Sep 26, 2025
35f76df
Merge pull request #20736 from A4-Tacks/fix-invert-if-let-chain
ShoyuVanilla Sep 26, 2025
acd320f
Merge pull request #20598 from A4-Tacks/let-chain-sup-conv-to-guarded…
ShoyuVanilla Sep 26, 2025
38284d1
Fix expand rest pattern in tuple and slice pattern
A4-Tacks Sep 23, 2025
c491a33
Merge pull request #20731 from A4-Tacks/expand-rest-pat-in-tuple-slic…
ShoyuVanilla Sep 26, 2025
f1e67f5
Merge pull request #20729 from A4-Tacks/const-param-kwd
ShoyuVanilla Sep 26, 2025
eb0cacb
Merge pull request #20604 from A4-Tacks/cfg-attr-comp
ShoyuVanilla Sep 26, 2025
a7df846
Merge pull request #20611 from A4-Tacks/replace-arith-op-prec
ShoyuVanilla Sep 26, 2025
93a96bf
Migrate `replace_arith_op` assist to use `SyntaxEditor`
A4-Tacks Sep 26, 2025
8d4c00d
Merge pull request #20599 from A4-Tacks/bang-de-morgan
ShoyuVanilla Sep 26, 2025
7de38d3
Merge pull request #20748 from A4-Tacks/migrate-arith-op-prec
ShoyuVanilla Sep 26, 2025
07bb89f
Update memchr to 2.7.6
neuschaefer Sep 26, 2025
2a10098
Merge pull request #20751 from neuschaefer/memchr
lnicola Sep 26, 2025
9d5adff
Bump tar-fs from 2.1.3 to 2.1.4 in /editors/code
dependabot[bot] Sep 26, 2025
6cfe1ec
Merge pull request #20753 from rust-lang/dependabot/npm_and_yarn/edit…
lnicola Sep 26, 2025
fdacc0c
Add `all` `any` and `not` attribute completions
A4-Tacks Sep 28, 2025
c0e45c8
Merge pull request #19867 from Kivooeo/unsafegate
Veykril Sep 28, 2025
50171eb
Prepare for merging from rust-lang/rust
invalid-email-address Sep 29, 2025
24f6f94
Merge ref 'f957826bff7a' from rust-lang/rust
invalid-email-address Sep 29, 2025
930451e
Merge pull request #20761 from rust-lang/rustc-pull
lnicola Sep 29, 2025
cd26daa
Merge pull request #20760 from A4-Tacks/all-any-not-attr-comp
ShoyuVanilla Sep 29, 2025
f4a865f
move test per review feedback
Sep 29, 2025
5969470
Merge pull request #20745 from Oblarg/fix-negative-int-literals-in-ma…
ShoyuVanilla Sep 30, 2025
fef8657
Impl `std::error::Error` for `SyntaxError`
ChayimFriedman2 Sep 30, 2025
8575ada
Merge pull request #20768 from ChayimFriedman2/std-error-syntaxerror
ChayimFriedman2 Sep 30, 2025
bf6f75f
Add regression test for another (long-standing) bug fixed by the new …
ChayimFriedman2 Sep 30, 2025
9cb7d98
Merge pull request #20769 from ChayimFriedman2/ns-cleanup4
ChayimFriedman2 Sep 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use crate::{AssistContext, AssistId, Assists};
// struct Bar { y: Y, z: Z }
//
// fn foo(bar: Bar) {
// let Bar { y, z } = bar;
// let Bar { y, z } = bar;
// }
// ```
fn expand_record_rest_pattern(
Expand Down Expand Up @@ -53,18 +53,17 @@ fn expand_record_rest_pattern(
|builder| {
let make = SyntaxFactory::with_mappings();
let mut editor = builder.make_editor(rest_pat.syntax());
let new_field_list = make.record_pat_field_list(old_field_list.fields(), None);
for (f, _) in missing_fields.iter() {
let field = make.record_pat_field_shorthand(
let new_fields = old_field_list.fields().chain(missing_fields.iter().map(|(f, _)| {
make.record_pat_field_shorthand(
make.ident_pat(
false,
false,
make.name(&f.name(ctx.sema.db).display_no_db(edition).to_smolstr()),
)
.into(),
);
new_field_list.add_field(field);
}
)
}));
let new_field_list = make.record_pat_field_list(new_fields, None);

editor.replace(old_field_list.syntax(), new_field_list.syntax());

Expand Down Expand Up @@ -214,7 +213,7 @@ enum Foo {
fn bar(foo: Foo) {
match foo {
Foo::A(_) => false,
Foo::B{ y, z } => true,
Foo::B{ y, z } => true,
};
}
"#,
Expand Down Expand Up @@ -275,7 +274,7 @@ struct Bar {
}

fn foo(bar: Bar) {
let Bar { y, z } = bar;
let Bar { y, z } = bar;
}
"#,
);
Expand Down Expand Up @@ -379,7 +378,7 @@ macro_rules! position {
position!(usize);

fn macro_call(pos: Pos) {
let Pos { x, y } = pos;
let Pos { x, y } = pos;
}
"#,
);
Expand Down Expand Up @@ -423,7 +422,7 @@ enum_gen!(usize);
fn macro_call(foo: Foo) {
match foo {
Foo::A(_) => false,
Foo::B{ x, y } => true,
Foo::B{ x, y } => true,
}
}
"#,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ fn foo(bar: Bar) {
struct Bar { y: Y, z: Z }

fn foo(bar: Bar) {
let Bar { y, z } = bar;
let Bar { y, z } = bar;
}
"#####,
)
Expand Down