Don't create a top-level true directory when running UI tests
#147217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
rustbot has assigned @petrochenkov. Use |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
davidtwco
approved these changes
Oct 1, 2025
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
|
I was going to file the compiletest check as a separate PR, but it would have been annoying to wait for this one to merge first, so I included the change in this PR instead. |
|
Strictly speaking this now requires reapproval due to the added compiletest changes; hopefully that will be swift. @bors r- |
bors
added
S-waiting-on-author
|
On second thought, let's just get the test fixed first. @bors r=petrochenkov |
bors
added
S-waiting-on-bors
This was referenced Oct 1, 2025
bors
added a commit
that referenced
this pull request
Oct 1, 2025
Rollup of 11 pull requests Successful merges: - #146918 (add regression test) - #146980 (simplify setup_constraining_predicates, and note it is potentially cubic) - #147170 (compiletest: Pass around `DirectiveLine` instead of bare strings) - #147180 (add tests) - #147188 (Remove usage of `compiletest-use-stage0-libtest` from CI) - #147189 (Replace `rustc_span::Span` with a stripped down version for librustdoc's highlighter) - #147199 (remove outdated comment in (inner) `InferCtxt`) - #147200 (Fix autodiff empty ret regression) - #147209 (Remove `no-remap-src-base` from tests) - #147213 (Fix broken STD build for ESP-IDF) - #147217 (Don't create a top-level `true` directory when running UI tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 1, 2025
Rollup merge of #147217 - Zalathar:true, r=petrochenkov Don't create a top-level `true` directory when running UI tests The funny thing about writing `-Cincremental=true` is that it *does* enable incremental compilation ... using an incremental compilation dir of `./true`. And for UI tests, that ends up creating a `true` directory in the repository root, which is annoying. Fortunately, compiletest has an existing `//@ incremental` directive that takes care of creating an empty incremental directory, and passing it to `-Cincremental`. --- I have manually checked that reverting #146649 still causes the updated test to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The funny thing about writing
-Cincremental=trueis that it does enable incremental compilation ... using an incremental compilation dir of./true.And for UI tests, that ends up creating a
truedirectory in the repository root, which is annoying.Fortunately, compiletest has an existing
//@ incrementaldirective that takes care of creating an empty incremental directory, and passing it to-Cincremental.I have manually checked that reverting #146649 still causes the updated test to fail.