Skip to content

Make #[link="dl"] an FCW rather than an error #147262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make #[link="dl"] an FCW rather than an error #147262

wants to merge 2 commits into from
+73 −9

Conversation

JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Oct 2, 2025 •
edited
Loading

Fixes #147254
I forgot to implement the T-lang decision in #143193 (comment), this implements that decision

r? @jdonszelmann
Can be reviewed commit-by-commit
This needs a beta backport

@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2025
@JonathanBrouwer JonathanBrouwer changed the title Make #[link="dl"] an FCW warning rather than an error Make #[link="dl"] an FCW rather than an error Oct 2, 2025
@cyrgani cyrgani added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 2, 2025
jieyouxu
jieyouxu requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test nits

View changes since this review

@apiraino
Copy link
Contributor

apiraino commented Oct 2, 2025

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 2, 2025
@traviscross traviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Oct 2, 2025
jieyouxu
jieyouxu approved these changes Oct 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with a test nit

View changes since this review

@jieyouxu jieyouxu self-assigned this Oct 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Oct 4, 2025

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 4, 2025
@JonathanBrouwer
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jdonszelmann jdonszelmann

@jieyouxu jieyouxu

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[link="dl"] should be an FCW, not a hard error. Affects 450+ crates.
7 participants
@JonathanBrouwer @rustbot @apiraino @jieyouxu @traviscross @jdonszelmann @cyrgani