-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Add check if span is from macro expansion #147421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks! |
Add check if span is from macro expansion The same thing I did in rust-lang#147416, actually the same bug but in another place, I'm not really sure how this method is good for fixing such ICEs, but, it does work and not conflicting with any existing tests, so I guess, it's fine Fixes rust-lang#147408 r? compiler
Rollup of 7 pull requests Successful merges: - #146187 (Unstably constify `ptr::drop_in_place` and related methods) - #146503 (std: improve handling of timed condition variable waits on macOS) - #147421 (Add check if span is from macro expansion) - #147630 (Bitset cleanups) - #147666 (Replace manual implementation with `carrying_mul_add`) - #147669 (fix missing link to `std::char` in `std` docs) - #147673 (pretty print u128 with display) r? `@ghost` `@rustbot` modify labels: rollup
Add check if span is from macro expansion The same thing I did in rust-lang#147416, actually the same bug but in another place, I'm not really sure how this method is good for fixing such ICEs, but, it does work and not conflicting with any existing tests, so I guess, it's fine Fixes rust-lang#147408 r? compiler
Rollup of 7 pull requests Successful merges: - #146187 (Unstably constify `ptr::drop_in_place` and related methods) - #146503 (std: improve handling of timed condition variable waits on macOS) - #147421 (Add check if span is from macro expansion) - #147630 (Bitset cleanups) - #147666 (Replace manual implementation with `carrying_mul_add`) - #147669 (fix missing link to `std::char` in `std` docs) - #147673 (pretty print u128 with display) r? `@ghost` `@rustbot` modify labels: rollup
Ngl I have no even close idea on why this could fail, like, is aarch64-pc-windows-msvc anyhow special from other targets? Or where specific I should take a look to understand reason of it |
@chenyukang could you take a look at this comment above, it's very confusingggg |
I think this is caused by the diff in stderr: - WARN rustc_errors::emitter Invalid span $SRC_DIR/std/src/macros.rs:LL:COL (#11), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "$SRC_DIR/std/src/macros.rs" }) }
+ WARN rustc_errors::emitter Invalid span $SRC_DIR/std/src/macros.rs:LL:COL (#11), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "/rustc/FAKE_PREFIX/library/std/src/macros.rs" }) } seems there is a difference in Windows. To ignore them, maybe you can have a try with https://rustc-dev-guide.rust-lang.org/tests/ui.html#normalization then retry it with:
|
if that does not help, you may ask for help at:#t-compiler/help. 👉 |
I already asked in zulip even before this message https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Windows.20path.20normalization.20in.20tests/with/545323081, but unfortunately no answers Could you do bors try just to make sure this isn't one-time random bug |
@bors try jobs=aarch64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
Add check if span is from macro expansion try-job: aarch64-msvc-1
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test for 9e2138d failed: CI. Failed jobs:
|
The same thing I did in #147416, actually the same bug but in another place, I'm not really sure how this method is good for fixing such ICEs, but, it does work and not conflicting with any existing tests, so I guess, it's fine
Fixes #147408
r? compiler