Skip to content

std: Use concat! and stringify! to simplify the most common assert! case #16703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Aug 24, 2014
Merged

std: Use concat! and stringify! to simplify the most common assert! case #16703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
std: Use concat! and stringify! to simplify the most common assert! c… 
…ase.

With no custom message, we should just use concat! + stringify! for
`assert!(expr)`.

Inspired by issue #16625
  • Loading branch information
root committed Aug 23, 2014
commit 262d5a4686c80675fe5bfcb79b26b341b9a0bf7a
2 changes: 1 addition & 1 deletion src/libstd/macros.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ macro_rules! fail(
macro_rules! assert(
($cond:expr) => (
if !$cond {
fail!("assertion failed: {:s}", stringify!($cond))
fail!(concat!("assertion failed: ", stringify!($cond)))
}
);
($cond:expr, $($arg:expr),+) => (
Expand Down