Skip to content

Add error explanation for E0317, E0154, E0259, E0260. #25267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 7 commits into from
May 13, 2015
Merged

Add error explanation for E0317, E0154, E0259, E0260. #25267

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d9e605
Add error explanation for E0317.
meqif May 10, 2015
c0412bc
Fix documentation URL in diagnostic message.
meqif May 10, 2015
f3a3684
Add error explanation for E0154.
meqif May 10, 2015
e7fa00a
Add error explanation for E0259.
meqif May 10, 2015
60ec4ab
Add error explanation for E0260.
meqif May 10, 2015
ef03055
Improve wording in error explanation.
meqif May 11, 2015
aa529ef
Add missing keyword in `extern crate` declarations.
meqif May 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing keyword in extern crate declarations.
  • Loading branch information
@meqif
meqif committed May 11, 2015
commit aa529ef52e54039fcfaa8aa7914be4c581179497
14 changes: 7 additions & 7 deletions src/librustc_resolve/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,17 @@ has been imported into the current module.

Wrong example:
```
extern a;
extern crate_a as a;
extern crate a;
extern crate crate_a as a;
```

The solution is to choose a different name that doesn't conflict with any
external crate imported into the current module.

Correct example:
```
extern a;
extern crate_a as other_name;
extern crate a;
extern crate crate_a as other_name;
```
"##,

Expand All @@ -72,7 +72,7 @@ The name for an item declaration conflicts with an external crate's name.

For instance,
```
extern abc;
extern crate abc;

struct abc;
```
Expand All @@ -82,15 +82,15 @@ There are two possible solutions:
Solution #1: Rename the item.

```
extern abc;
extern crate abc;

struct xyz;
```

Solution #2: Import the crate with a different name.

```
extern abc as xyz;
extern crate abc as xyz;

struct abc;
```
Expand Down