Skip to content

Forbid items with the same name from appearing in overlapping inherent impl blocks #31925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 5 commits into from
Mar 12, 2016
Merged

Forbid items with the same name from appearing in overlapping inherent impl blocks #31925

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cc3bfc
Introduce `ImplHeader`
aturon Feb 26, 2016
21df87f
Forbid items with the same name being defined in overlapping inherent
aturon Feb 26, 2016
4b4c6fd
Add regression test for duplicate items in overlapping impls. Note th…
aturon Feb 26, 2016
2234b55
Adjust tests to new error message
aturon Mar 9, 2016
6265b6b
Adjust rustdoc test for new restriction
aturon Mar 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adjust rustdoc test for new restriction
  • Loading branch information
@aturon
aturon committed Mar 11, 2016
commit 6265b6bec872240adf3cb72eecd6b0cae8627014
6 changes: 3 additions & 3 deletions src/test/rustdoc/issue-25001.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ pub trait Bar {
fn quux(self);
}

impl<T> Foo<T> {
impl Foo<u8> {
// @has - '//*[@id="method.pass"]//code' 'fn pass()'
pub fn pass() {}
}
impl<T> Foo<T> {
impl Foo<u16> {
// @has - '//*[@id="method.pass-1"]//code' 'fn pass() -> usize'
pub fn pass() -> usize { 42 }
}
impl<T> Foo<T> {
impl Foo<u32> {
// @has - '//*[@id="method.pass-2"]//code' 'fn pass() -> isize'
pub fn pass() -> isize { 42 }
}
Expand Down