Skip to content

rustdoc: Add doc snippets for trait impls, with a read more link #33679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
May 21, 2016
Merged

rustdoc: Add doc snippets for trait impls, with a read more link #33679

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38e1797
rustdoc: Add doc snippets for trait impls, with a read more link
Manishearth May 17, 2016
8e94b04
rustdoc: Support short doc fallback for non-default items
Manishearth May 17, 2016
74633b0
Move read more link to same line
Manishearth May 18, 2016
9ce018b
Update tests
Manishearth May 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move read more link to same line
  • Loading branch information
@Manishearth
Manishearth committed May 18, 2016
commit 74633b08e057d62fcd2c221c305fe854c4189f04
11 changes: 6 additions & 5 deletions src/librustdoc/html/render.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,11 +1659,12 @@ fn document(w: &mut fmt::Formatter, cx: &Context, item: &clean::Item) -> fmt::Re

fn document_short(w: &mut fmt::Formatter, item: &clean::Item, link: AssocItemLink) -> fmt::Result {
if let Some(s) = item.doc_value() {
write!(w, "<div class='docblock'>{}", Markdown(&plain_summary_line(Some(s))))?;
if s.contains('\n') {
write!(w, "<a href='{}'>Read more</a>", naive_assoc_href(item, link))?;
}
write!(w, "</div>")?;
let markdown = if s.contains('\n') {
format!("{} [Read more]({})", &plain_summary_line(Some(s)), naive_assoc_href(item, link))
} else {
format!("{}", &plain_summary_line(Some(s)))
};
write!(w, "<div class='docblock'>{}</div>", Markdown(&markdown))?;
}
Ok(())
}
Expand Down