Increase spacing in error format for readability. #33820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… another line between errors
|
Maybe this is a good chance for a UI test! |
|
Failed in Travis due to a UI test. |
|
@nikomatsakis - updated and fixed troublesome errors using UI test or check_old_skool if they couldn't easily be a UI test. Fixed a couple other small issues in the process. Also, went from two spaces between errors back to one space. |
|
@bors r+ |
|
📌 Commit df87a78 has been approved by |
|
⌛ Testing commit df87a78 with merge a599e86... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit df87a78 with merge d2d2b8b... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 28, 2016
…updates, r=nikomatsakis Increase spacing in error format for readability. Two small tweaks that seem to help readability quite a bit: * Add spacing header<->snippet, but use the |> on the side for visual consistency * Fix rust-lang#33819 * Fix rust-lang#33763 * Move format-sensitive test (issue-26480 in cfail) to ui test r? @nikomatsakis
|
⛄ The build was interrupted to prioritize another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small tweaks that seem to help readability quite a bit:
r? @nikomatsakis