Skip to content

Unnecessary iteration in BTreeMap::drop #40790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Mar 25, 2017
Merged

Unnecessary iteration in BTreeMap::drop #40790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Unnecessary iteration in BTreeMap::drop 
`IntoIter::drop` already iterates.
  • Loading branch information
@stepancheg
stepancheg committed Mar 24, 2017
commit f97b3f08cde6dff89c8c236fce2479725d7f909e
3 changes: 1 addition & 2 deletions src/libcollections/btree/map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ pub struct BTreeMap<K, V> {
unsafe impl<#[may_dangle] K, #[may_dangle] V> Drop for BTreeMap<K, V> {
fn drop(&mut self) {
unsafe {
for _ in ptr::read(self).into_iter() {
}
drop(ptr::read(self).into_iter());
}
}
}
Expand Down