Skip to content

Fix since for mpsc_error_conversions #46323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2017
Merged

Fix since for mpsc_error_conversions #46323

merged 1 commit into from
Nov 29, 2017

Conversation

ia0
Copy link
Contributor

@ia0 ia0 commented Nov 28, 2017

This is a followup of #45506.

@ia0 ia0 mentioned this pull request Nov 28, 2017
Merged
@kennytm
Copy link
Member

kennytm commented Nov 28, 2017

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 28, 2017

📌 Commit 52b0f42 has been approved by kennytm

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 28, 2017
@ia0 ia0 force-pushed the fix_mpsc_error_conv branch from 52b0f42 to 43323b3 Compare November 28, 2017 14:59
@ia0
Copy link
Contributor Author

ia0 commented Nov 28, 2017

I had to force push to the branch to fix my name and email address in the commit (the commit content did not change). Sorry for that.

@kennytm
Copy link
Member

kennytm commented Nov 28, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2017

📌 Commit 43323b3 has been approved by kennytm

@ia0
Copy link
Contributor Author

ia0 commented Nov 28, 2017

Thanks for the quick review @kennytm!

kennytm added a commit to kennytm/rust that referenced this pull request Nov 29, 2017
@kennytm
Rollup merge of rust-lang#46323 - ia0:fix_mpsc_error_conv, r=kennytm
30f1853 
Fix since for mpsc_error_conversions

This is a followup of rust-lang#45506.
@kennytm kennytm mentioned this pull request Nov 29, 2017
Merged
bors added a commit that referenced this pull request Nov 29, 2017
@bors
Auto merge of #46362 - kennytm:rollup, r=kennytm
0a2e9ad 
Rollup of 10 pull requests

- Successful merges: #45969, #46077, #46219, #46287, #46293, #46322, #46323, #46330, #46354, #46356
- Failed merges:
@bors bors merged commit 43323b3 into rust-lang:master Nov 29, 2017
@ia0 ia0 deleted the fix_mpsc_error_conv branch May 26, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ia0 @kennytm @bors