Skip to content

Modify message for keyword as identifier name #46497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 6 commits into from
Dec 7, 2017
Merged

Modify message for keyword as identifier name #46497

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65ccf24
and refactor to just move the checking
Dec 6, 2017
ce1fed7
address comments
Dec 7, 2017
fb8ab18
remove unnecessary function
Dec 7, 2017
8647b9d
remove unnecessary changes
Dec 7, 2017
dd41929
remove unused test
Dec 7, 2017
29e2680
remove unnecessary change
Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused test
  • Loading branch information
Agustin Chiappe Berrini committed Dec 7, 2017
commit dd4192950912b6dcf7b0ae23a93c801b9ce8c0b0
20 changes: 0 additions & 20 deletions src/libsyntax_pos/symbol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,26 +433,6 @@ mod tests {
assert_eq!(i.gensym("dog"), Symbol(4294967293));
}

#[test]
fn is_used_keyword_test() {
let s = Symbol(5);
assert_eq!(s.is_used_keyword(), true);
}

#[test]
fn is_unused_keyword_test() {
let s = Symbol(40);
assert_eq!(s.is_unused_keyword(), true);
}

#[test]
fn is_valid_test() {
let i = Ident { name: Symbol(40), ctxt: SyntaxContext(0) };
assert_eq!(i.is_valid(), false);
let i = Ident { name: Symbol(61), ctxt: SyntaxContext(0) };
assert_eq!(i.is_valid(), true);
}

#[test]
fn without_first_quote_test() {
let i = Ident::from_str("'break");
Expand Down