-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Suggest type for overflowing bin/hex-literals #48432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e822e62
Suggest type for overflowing bin/hex-literals
flip1995 19c4771
Implementing requested changes
flip1995 5c70619
Rewrite error reporting as requested
flip1995 f45f760
Adapt stderr of UI test to PR #48449
flip1995 15ecf06
Remove isize test
flip1995 fc33b25
Improve getting literal representation
flip1995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adapt stderr of UI test to PR #48449
- Loading branch information
commit f45f760f624b34a7fa70fe925303808d4713641a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note says that the literal will become
-1i8(which is technically correct), whilefailwill have the value1i8due to the negation. That is, because I ignore whether the literal is negated in the generation of the note.I'm not sure if I should change this because it is correct for the given span.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is fine for now. Filed #48535 to follow up.