Skip to content

address some FIXME whose associated issues were marked as closed #49117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 15 commits into from
Mar 22, 2018
Merged

address some FIXME whose associated issues were marked as closed #49117

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7278e37
update FIXME(#6393) to point to issue 43234 (tracking issue for non-l…
nivkner Dec 9, 2017
ba836f4
update FIXME(#15760) to point to issue 27336 (tracking issue for Defa…
nivkner Mar 16, 2018
d1dacdd
update FIXME(#7622) to point to issue 44580 (tracking issue for const…
nivkner Mar 17, 2018
e1b9bf0
update FIXME(#23442) to point to issue 45742 (Blanket impl of AsRef f…
nivkner Mar 17, 2018
3753e1a
update FIXME(#5244) to point to RFC 1109 (Non-Copy array creation erg…
nivkner Mar 16, 2018
4a06708
remove FIXME(#39119) and allow running test on emscripten
nivkner Dec 9, 2017
622c445
remove FIXME(#37712) and implement ItemLikeVisitor instead of Visitor
nivkner Dec 9, 2017
69d12a2
remove FIXME(#30046) and infer moves on pattern matching
nivkner Mar 16, 2018
fd00755
remove FIXME(#11094) and allow make tests to run on targets besides host
nivkner Mar 17, 2018
2c6b7b9
remove FIXME(#2543) and avoid bad copies
nivkner Mar 17, 2018
0d8fa82
remove FIXME(#48116) and remove the logic to debug the issue
nivkner Mar 16, 2018
be73a1f
remove FIXME(#33435) and remove the spurious failures counter measure
nivkner Mar 17, 2018
c8be5c3
remove FIXME(#8372) since for-loops wont support borrowing iterators
nivkner Mar 17, 2018
d5b55c1
remove FIXME(#27889) since the issue is already fixed
nivkner Mar 17, 2018
66d120c
Revert "remove FIXME(#33435) and remove the spurious failures counter…
nivkner Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update FIXME(#5244) to point to RFC 1109 (Non-Copy array creation erg… 
…onomics)
  • Loading branch information
@nivkner
nivkner committed Mar 17, 2018
commit 3753e1a55a2ed118121779e05f77164da3269a86
2 changes: 1 addition & 1 deletion src/liballoc/tests/slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ fn test_copy_from_slice_dst_shorter() {
const MAX_LEN: usize = 80;

static DROP_COUNTS: [AtomicUsize; MAX_LEN] = [
// FIXME #5244: AtomicUsize is not Copy.
// FIXME(RFC 1109): AtomicUsize is not Copy.
AtomicUsize::new(0), AtomicUsize::new(0), AtomicUsize::new(0), AtomicUsize::new(0),
AtomicUsize::new(0), AtomicUsize::new(0), AtomicUsize::new(0), AtomicUsize::new(0),
AtomicUsize::new(0), AtomicUsize::new(0), AtomicUsize::new(0), AtomicUsize::new(0),
Expand Down