Skip to content

Suggest to take and ignore args while closure args count mismatching #52647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 7 commits into from
Jul 26, 2018
Merged

Suggest to take and ignore args while closure args count mismatching #52647

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87f0c1f
Suggest to take and ignore args while closure args count mismatching
csmoe Jul 23, 2018
27c0d56
Mark the suggestion applicable
csmoe Jul 23, 2018
a71deb2
Fix ui test
csmoe Jul 24, 2018
9492176
Suggest in separate line
csmoe Jul 25, 2018
40c0339
Fix test
csmoe Jul 25, 2018
d5256b7
Update comment and do suggest
csmoe Jul 25, 2018
1d79588
Update ui test
csmoe Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ui test
  • Loading branch information
@csmoe
csmoe committed Jul 24, 2018
commit a71deb2633eeaf03f64ae0ee3b389128ec06f392
12 changes: 8 additions & 4 deletions src/test/ui/mismatched_types/closure-arg-count.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ error[E0593]: closure is expected to take 2 arguments, but it takes 0 arguments
--> $DIR/closure-arg-count.rs:15:15
|
LL | [1, 2, 3].sort_by(|| panic!());
| ^^^^^^^ -- takes 0 arguments
| |
| ^^^^^^^ --
| | |
| | takes 0 arguments
| | help: change the closure to take and ignore the arguments: `|_, _|`
Copy link
Contributor Author

@csmoe csmoe Jul 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estebank the position of this help message is a bit weird since I span_suggestion_with_applicability the same way as the tuple-args do. what I want:

    |
 help: change the closure to take multiple arguments instead of a single tuple
    |
 LL |     [1, 2, 3].sort_by(|tuple, tuple2| panic!());
    |                       ^^^^^^^^^^^^^^^

How to fix this?

Copy link
Contributor

@estebank estebank Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions that have fewer than 10 words (among other things) are emitted as above, inline. Making the message longer is one of the ways of ensuring the separate suggestion line.

| expected closure that takes 2 arguments

error[E0593]: closure is expected to take 2 arguments, but it takes 1 argument
Expand Down Expand Up @@ -42,8 +44,10 @@ error[E0593]: closure is expected to take 1 argument, but it takes 0 arguments
--> $DIR/closure-arg-count.rs:23:5
|
LL | f(|| panic!());
| ^ -- takes 0 arguments
| |
| ^ --
| | |
| | takes 0 arguments
| | help: change the closure to take and ignore the argument: `|_|`
| expected closure that takes 1 argument
|
note: required by `f`
Expand Down