Skip to content

miri enum discriminant handling: Fix treatment of pointers, better error when it is undef #55894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Nov 19, 2018
Merged

miri enum discriminant handling: Fix treatment of pointers, better error when it is undef #55894

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffb6ba0
validation: better error when the enum discriminant is Undef
RalfJung Nov 12, 2018
a3770c2
do not accept out-of-bounds pointers in enum discriminants, they migh…
RalfJung Nov 12, 2018
b8915f2
fix other affected tests
RalfJung Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix other affected tests
  • Loading branch information
@RalfJung
RalfJung committed Nov 15, 2018
commit b8915f2ba83d2d7968a1615a086bde0d4bf20706
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ error[E0080]: it is undefined behavior to use this value
--> $DIR/issue-52023-array-size-pointer-cast.rs:12:17
|
LL | let _ = [0; (&0 as *const i32) as usize]; //~ ERROR casting pointers to integers in constants
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected initialized plain bits
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected initialized plain (non-pointer) bytes
|
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior

Expand Down