Skip to content

Simplify Iterator::{min, max} #59138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2019
Merged

Simplify Iterator::{min, max} #59138

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d18e57
Fix the bench_max and bench_max_by_key benchmarks
timvermeulen Mar 12, 2019
b23a047
Remove the projection part of select_fold1
timvermeulen Mar 12, 2019
0de63d9
Fix comment
timvermeulen Mar 12, 2019
1819250
Add tests to ensure that Iterator::min and Iterator::max are stable
timvermeulen Mar 12, 2019
6cc5a3d
Forward `max` and `min` to `max_by` and `min_by` respectively
timvermeulen Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix comment
  • Loading branch information
@timvermeulen
timvermeulen committed Mar 12, 2019
commit 0de63d901b8ec550179b17ea06756e679b9fd461
2 changes: 1 addition & 1 deletion src/libcore/iter/traits/iterator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,7 +2125,7 @@ pub trait Iterator {
fn min_by<F>(self, mut compare: F) -> Option<Self::Item>
where Self: Sized, F: FnMut(&Self::Item, &Self::Item) -> Ordering,
{
// switch to y even if it is strictly smaller, to preserve stability.
// only switch to y if it is strictly smaller, to preserve stability.
select_fold1(self, |x, y| compare(x, y) == Ordering::Greater)
}

Expand Down