Skip to content

use visitor for #[structural_match] check #62339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 6 commits into from
Jul 10, 2019
Merged

use visitor for #[structural_match] check #62339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
507ee72
Note that `eq_trait` denotes `trait PartialEq`, not `Eq`, so you don'…
pnkfelix Jul 8, 2019
36777f1
future-compat lint for newly handled cases of `#[structural_match]`.
pnkfelix Jul 8, 2019
b560801
Rewrite with future-compat lint for indirect pattern omitting
pnkfelix Jul 3, 2019
02714b8
Regression tests and updates to existing tests.
pnkfelix Jul 3, 2019
02af3ca
Added test explicitly testing that this PR continues to handle empty …
pnkfelix Jul 8, 2019
b0b64dd
Added comment explaining purpose of `search_for_adt_without_structura…
pnkfelix Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
future-compat lint for newly handled cases of #[structural_match].
  • Loading branch information
@pnkfelix
pnkfelix committed Jul 8, 2019
commit 36777f157b1f30f208e913c0ec04f9ac6b567a4e
6 changes: 6 additions & 0 deletions src/librustc/lint/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,12 @@ declare_lint! {
"outlives requirements can be inferred"
}

declare_lint! {
pub INDIRECT_STRUCTURAL_MATCH,
Warn,
"pattern with const indirectly referencing non-`#[structural_match]` type"
}

/// Some lints that are buffered from `libsyntax`. See `syntax::early_buffered_lints`.
pub mod parser {
declare_lint! {
Expand Down
5 changes: 5 additions & 0 deletions src/librustc_lint/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,11 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) {
id: LintId::of(MUTABLE_BORROW_RESERVATION_CONFLICT),
reference: "issue #59159 <https://github.com/rust-lang/rust/issues/59159>",
edition: None,
},
FutureIncompatibleInfo {
id: LintId::of(INDIRECT_STRUCTURAL_MATCH),
reference: "issue #62411 <https://github.com/rust-lang/rust/issues/62411>",
edition: None,
}
]);

Expand Down