Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
75ab3a8
Stabilize rustdoc theme options
GuillaumeGomez Oct 1, 2018
272799f
Add documentation for stabilized flags
GuillaumeGomez May 23, 2019
ca64df5
Warn instead of failing for themes
GuillaumeGomez May 23, 2019
10e6ca6
Apply review comments
GuillaumeGomez May 24, 2019
8df4ce2
add test for rustdoc's --themes flag
QuietMisdreavus May 24, 2019
2aa57e9
Prevent invalid html characters in themes name
GuillaumeGomez Jun 30, 2019
5b2862c
Add sentence to tell other options are ignored when running check-theme
GuillaumeGomez Jun 30, 2019
2f535a4
Rename theme-checker option to check-theme
GuillaumeGomez Jun 30, 2019
29494a8
Fix typos
GuillaumeGomez Jul 26, 2019
b65a369
Improve documentation, add checks for themes option arguments, make s…
GuillaumeGomez Aug 21, 2019
c45a553
rename check-theme option into check-themes
GuillaumeGomez Sep 14, 2019
747dcaf
remove unstable docs
GuillaumeGomez Sep 14, 2019
94b21eb
Rename rustdoc options --themes and --check-themes to --theme and --c…
GuillaumeGomez Sep 22, 2019
c614cad
Apply review comments
GuillaumeGomez Oct 10, 2019
82a7b32
remove -Z option from rustdoc theme checker tool
GuillaumeGomez Oct 12, 2019
1ebb9ec
improve error messages and documentation
GuillaumeGomez Oct 17, 2019
1907589
rustdoc: Stabilize `edition` annotation.
ehuss Nov 9, 2019
71cf364
Fix the source code highlighting on source comments
dns2utf8 Nov 15, 2019
1bbb816
Prevent jumps when selecting one or many lines
dns2utf8 Nov 15, 2019
4e1eeb9
Add explanation message for E0641
clemkoh Nov 16, 2019
dc137dd
Update ui tests
clemkoh Nov 16, 2019
e0d2d9d
Rollup merge of #54733 - GuillaumeGomez:stabilize-rustdoc-theme, r=Dy…
GuillaumeGomez Nov 17, 2019
18668f9
Rollup merge of #66238 - ehuss:stabilize-rustdoc-edition, r=Guillaume…
GuillaumeGomez Nov 17, 2019
62ebeb8
Rollup merge of #66430 - dns2utf8:fix_code_selection_click_handler, r…
GuillaumeGomez Nov 17, 2019
e4b2089
Rollup merge of #66461 - clemencetbk:master, r=GuillaumeGomez
GuillaumeGomez Nov 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Warn instead of failing for themes
  • Loading branch information
GuillaumeGomez committed Sep 25, 2019
commit ca64df5eecaea79a4f1cf7536ea8bd337000895a
3 changes: 1 addition & 2 deletions src/librustdoc/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,9 @@ impl Options {
}
let (success, ret) = theme::test_theme_against(&theme_file, &paths, &diag);
if !success || !ret.is_empty() {
diag.struct_err(&format!("invalid theme: \"{}\"", theme_s))
diag.struct_warn(&format!("invalid theme: \"{}\"", theme_s))
.help("check what's wrong with the --theme-checker option")
.emit();
return Err(1);
}
themes.push(theme_file);
}
Expand Down
1 change: 1 addition & 0 deletions src/librustdoc/theme.rs
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ pub fn test_theme_against<P: AsRef<Path>>(
diag: &Handler,
) -> (bool, Vec<String>) {
let data = try_something!(fs::read(f), diag, (false, vec![]));

let paths = load_css_paths(&data);
let mut ret = vec![];
get_differences(against, &paths, &mut ret);
Expand Down