Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
f79ba85
clean up E0185 explanation
GuillaumeGomez Jan 9, 2020
f45758c
Compile some CGUs in parallel at the start of codegen
Zoxc Jan 5, 2020
69bacd0
Precompile CGUs while the main thread has the implicit job server token
Zoxc Jan 8, 2020
54f8601
Fix ICE #68058
JohnTitor Jan 9, 2020
a59abfa
Revert const_eval call to use const_eval_raw to avoid const validatio…
spastorino Dec 31, 2019
1688719
Promote `Ref`s to constants instead of static
spastorino Nov 22, 2019
2508f17
Promote `Repeat`s to constants instead of statics
spastorino Dec 10, 2019
32fe477
Promote `Argument`s to constants instead of statics
spastorino Dec 11, 2019
6aa4b5a
Add promoted_operand closure to reuse code across different
spastorino Dec 11, 2019
6f2c702
Remove StaticKind::Promoted
spastorino Dec 11, 2019
b63597d
Remove StaticKind
spastorino Dec 11, 2019
fb2f0ec
Use if let instead of match with one meaningful arm
spastorino Dec 11, 2019
9e70c47
Remove unused param_env parameter
spastorino Dec 11, 2019
fd5aa32
Remove Static from PlaceBase
spastorino Dec 11, 2019
5d9b399
Remove PlaceBase enum and make Place base field be local: Local
spastorino Dec 11, 2019
a9de4f1
Fix print const on librustdoc
spastorino Dec 13, 2019
7f3459a
No need to use local.into here
spastorino Dec 13, 2019
a5715a3
Use re_erased instead of re_static
spastorino Dec 19, 2019
8533caa
Make Place Copy
spastorino Dec 19, 2019
1565612
Add span_bug that notes that shuffle indices must be constant
spastorino Dec 19, 2019
36b1756
Do not store lint_root
spastorino Jan 1, 2020
6e1bbff
Promoteds also need param envs.
oli-obk Jan 8, 2020
ecd5852
Errors in promoteds may only cause lints not hard errors
oli-obk Jan 8, 2020
050146f
Add regression tests for promotion mir expansion
oli-obk Jan 9, 2020
43313d5
Remove an outdated comment
oli-obk Jan 9, 2020
a5d8ab7
Rebase fallout
oli-obk Jan 9, 2020
c899f67
Improve E0185 wording
GuillaumeGomez Jan 10, 2020
4fadb50
Update E0185.md
Dylan-DPC Jan 10, 2020
f3ce144
Run codegen unit partitioning and assert_symbols_are_distinct in para…
Zoxc Dec 31, 2019
4beeadd
Fix a deadlock
Zoxc Dec 31, 2019
51a73eb
Avoid a duplicate hash map lookup
Zoxc Dec 31, 2019
4a64716
Add a comment
Zoxc Jan 10, 2020
48cad46
Fix test not to depend on environment
JohnTitor Jan 11, 2020
8f1df30
Only require `allow_internal_unstable` for stable `const fn`
ecstatic-morse Jan 11, 2020
09b5c85
Remove unnecessary `const_fn` feature gates
ecstatic-morse Jan 11, 2020
1d418a1
Test that stable `const fn` requires `allow_internal_unstable`
ecstatic-morse Jan 11, 2020
a5f4239
Rename Result::as_deref_ok to as_deref
tesuji Jan 6, 2020
c2c2d3b
Update test after renaming Result::as_deref
tesuji Jan 7, 2020
fc30825
Expand comment
ecstatic-morse Jan 11, 2020
883932c
Ban `...X` pats, harden tests, and improve diagnostics.
Centril Jan 11, 2020
8e35c4f
feature_gate: Remove `GateStrength`
petrochenkov Jan 8, 2020
020c465
Rollup merge of #67000 - spastorino:remove-promoted-from-place, r=oli…
Centril Jan 11, 2020
f5077d7
Rollup merge of #67756 - Zoxc:collector-tweaks, r=Mark-Simulacrum
Centril Jan 11, 2020
72bf6f4
Rollup merge of #67889 - Zoxc:parallel-cgus, r=michaelwoerister
Centril Jan 11, 2020
1691ee2
Rollup merge of #67930 - lzutao:result-as_deref, r=dtolnay
Centril Jan 11, 2020
71a719c
Rollup merge of #68018 - petrochenkov:nosoft, r=Centril
Centril Jan 11, 2020
b2027df
Rollup merge of #68070 - GuillaumeGomez:clean-up-e0185, r=Dylan-DPC
Centril Jan 11, 2020
544c981
Rollup merge of #68072 - JohnTitor:fix-macro-ice, r=petrochenkov
Centril Jan 11, 2020
b00abbe
Rollup merge of #68114 - ecstatic-morse:fix-feature-gating, r=Centril
Centril Jan 11, 2020
b8f6eb9
Rollup merge of #68120 - Centril:ban-range-to-dotdotdot, r=oli-obk
Centril Jan 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert const_eval call to use const_eval_raw to avoid const validatio…
…n cycles
  • Loading branch information
spastorino authored and oli-obk committed Jan 10, 2020
commit a59abfa450cf9d18d725c2b757686fd4b65ccbe5
7 changes: 6 additions & 1 deletion src/librustc_mir/interpret/operand.rs
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,12 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
// happening.
// FIXME(oli-obk): eliminate all the `const_eval_raw` usages when we get rid of
// `StaticKind` once and for all.
return self.const_eval(GlobalId { instance, promoted: None });
// FIXME the following line should have been:
// return self.const_eval(GlobalId { instance, promoted });
// but since the addition of Promoteds being Constants is causing const validation
// cycles. Promoteds being Constants exercise const validation more often and it
// may have made show up a pre-existing bug.
return Ok(OpTy::from(self.const_eval_raw(GlobalId { instance, promoted })?));
}
ty::ConstKind::Infer(..)
| ty::ConstKind::Bound(..)
Expand Down