Skip to content

Polonius: update to 0.12.1, fix more move errors false positives, update test expectations #70546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 7 commits into from
Mar 30, 2020
Merged

Polonius: update to 0.12.1, fix more move errors false positives, update test expectations #70546

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df1ac67
update polonius-engine to 0.12.1
lqd Mar 29, 2020
860f71f
Polonius fact generation: fix path access fact location
lqd Mar 29, 2020
2a76447
bless output of ui test hrtb/hrtb-perfect-forwarding.rs
lqd Mar 29, 2020
c73d5db
bless output of ui test nll/outlives-suggestion-simple.rs
lqd Mar 29, 2020
fcd12bd
bless output of ui test closures/closure-expected-type/expect-region-…
lqd Mar 29, 2020
8242463
bless output of ui test impl-trait/multiple-lifetimes/error-handling.rs
lqd Mar 29, 2020
5af11d2
bless output of ui test nll/user-annotations/closure-substs.rs
lqd Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polonius fact generation: fix path access fact location 
This will fix the other move errors false positives:
emitting the fact at the start point caused accesses to be at the
same point as an initialization fact of the return place of a call
on the following block, which emitted an error.
  • Loading branch information
@lqd
lqd committed Mar 29, 2020
commit 860f71f141baf8228a9d71a75092ff2378bfee42
2 changes: 1 addition & 1 deletion src/librustc_mir/borrow_check/type_check/liveness/polonius.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ impl UseFactsExtractor<'_> {

fn insert_path_access(&mut self, path: MovePathIndex, location: Location) {
debug!("UseFactsExtractor::insert_path_access({:?}, {:?})", path, location);
self.path_accessed_at_base.push((path, self.location_table.start_index(location)));
self.path_accessed_at_base.push((path, self.location_to_index(location)));
}

fn place_to_mpi(&self, place: &Place<'_>) -> Option<MovePathIndex> {
Expand Down