Skip to content

Document the union keyword #73867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2020
Merged

Document the union keyword #73867

merged 2 commits into from
Jul 14, 2020

Conversation

poliorcetics
Copy link
Contributor

Partial fix of #34601.

This documents the union keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement

@rustbot rustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jun 29, 2020
@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2020
@poliorcetics poliorcetics mentioned this pull request Jun 29, 2020
Closed
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett reviewed Jun 30, 2020
View reviewed changes
joshtriplett
joshtriplett requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@joshtriplett joshtriplett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted review comments with some minor changes. Overall, looks good, thank you!

@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 12, 2020

📌 Commit 614f773 has been approved by joshtriplett

@bors
Copy link
Collaborator

bors commented Jul 12, 2020

🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#73867 - poliorcetics:union-keyword, r=josht…
273444e 
…riplett

Document the union keyword

Partial fix of rust-lang#34601.

This documents the `union` keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#73867 - poliorcetics:union-keyword, r=josht…
903a81a 
…riplett

Document the union keyword

Partial fix of rust-lang#34601.

This documents the `union` keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#73867 - poliorcetics:union-keyword, r=josht…
cb0d9e8 
…riplett

Document the union keyword

Partial fix of rust-lang#34601.

This documents the `union` keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#73867 - poliorcetics:union-keyword, r=josht…
0663d5e 
…riplett

Document the union keyword

Partial fix of rust-lang#34601.

This documents the `union` keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
@Manishearth
Rollup merge of rust-lang#73867 - poliorcetics:union-keyword, r=josht…
d8f6613 
…riplett

Document the union keyword

Partial fix of rust-lang#34601.

This documents the `union` keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
@Manishearth
Rollup merge of rust-lang#73867 - poliorcetics:union-keyword, r=josht…
8f767c9 
…riplett

Document the union keyword

Partial fix of rust-lang#34601.

This documents the `union` keyword by presenting three cases: simply using a union, matching on a union and referencing the fields of a union.

@rustbot modify labels: T-doc,C-enhancement
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2020
@bors
Auto merge of rust-lang#74313 - Manishearth:rollup-b55rn6t, r=Manishe…
4a689da 
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#73354 (Update RELEASES.md for 1.45.0)
 - rust-lang#73852 (rustdoc: insert newlines between attributes)
 - rust-lang#73867 (Document the union keyword)
 - rust-lang#74046 (Fix caching issue when building tools.)
 - rust-lang#74123 (clean up E0718 explanation)
 - rust-lang#74147 (rustdoc: Allow linking from private items to private types)
 - rust-lang#74285 (rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics)
 - rust-lang#74286 (Added detailed error code explanation for issue E0688 in Rust compiler.)

Failed merges:

r? @ghost
@bors bors merged commit d9614db into rust-lang:master Jul 14, 2020
@poliorcetics poliorcetics deleted the union-keyword branch July 14, 2020 10:35
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett approved these changes

Assignees

@joshtriplett joshtriplett

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@poliorcetics @rust-highfive @joshtriplett @bors @cuviper @rustbot