[WIP] incomplete attempt to inject additional coverage for unused MIR #79392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions (including generics and including async function bodies (which mimic closures with generics/type parameters) that aren't invoked are not appearing in coverage reports. They don't get a zero (0) execution count. They get nothing, and they don't appear in reports as "not covered" code to be addressed. I attempted to inject "Zero" counters for each of these, but `llvm-cov` fails if the coverage map has a counter for a function that is non defined.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
FYI, this doesn't solve the problem of adding coverage for MIR that was not promoted to a MonoItem, but I wanted to keep the code (in a separate PR) in case I want to build from it later. Or it may never get used, which is fine. Until we know more, I'm just saving a shapshot. |
|
r? @tmandry |
|
BTW, some test samples were added and/or modified, but the blessed "expected" files were not regenerated, so the PR will fail to build as it currently exists. |
|
The lessons learned from this PR were successfully incorporated into PR #79109. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions (including generics and including async function bodies (which
mimic closures with generics/type parameters) that aren't invoked are
not appearing in coverage reports. They don't get a zero (0) execution
count. They get nothing, and they don't appear in reports as "not
covered" code to be addressed.
I attempted to inject "Zero" counters for each of these, but
llvm-covfails if the coverage map has a counter for a function that is non
defined.
@tmandry