Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
949b125
Add unit tests for new lint
nahuakang Jan 27, 2021
5753614
Draft skeleton for new lint
nahuakang Jan 27, 2021
3da25ed
Rename lint
nahuakang Jan 27, 2021
8973f2c
Run cargo dev update_lints
nahuakang Jan 27, 2021
b87e189
Implement manual flatten lint
nahuakang Jan 29, 2021
7825bf3
Fix suggestions that need parens
ThibsG Jan 31, 2021
e07cd5b
Enhance manual flatten
nahuakang Feb 2, 2021
c8cb90a
Merge commit '3e4179766bcecd712824da04356621b8df012ea4' into sync-fro…
Manishearth Feb 3, 2021
0f5e71f
Add additional check on if arg type has iter method
nahuakang Feb 3, 2021
f2e82af
Use PrimTy in builtin type shadow lint
camsteffen Feb 2, 2021
6396b8f
Fix file names of flat_map_identity test
magurotuna Feb 3, 2021
876ffa4
Auto merge of #6669 - magurotuna:fix-test-name, r=flip1995
bors Feb 3, 2021
78ef0f2
Add additional test cases and improve span lint
nahuakang Feb 3, 2021
0767a0f
Fix/allow non_fmt_panic in clippy tests.
m-ou-se Feb 2, 2021
9f7f8b7
Suggest panic!("{}", ..) instead of panic!(..) clippy::expect_fun_call.
m-ou-se Feb 3, 2021
2f8a8d3
Improve lint message; add note for future autofixable updates
nahuakang Feb 4, 2021
357c6a7
Auto merge of #6646 - nahuakang:for_loops_over_options_or_results, r=…
bors Feb 4, 2021
233fe11
Set turbofish for every sugg and add more test cases
ThibsG Feb 4, 2021
7b7e3ca
Support free functions in disallowed-methods lint
phlip9 Jan 30, 2021
67d48e1
fix typo
TaKO8Ki Feb 5, 2021
79dbf10
Use absolute path to Rust repo in ra_setup
flip1995 Feb 5, 2021
56f7fbb
Cleanup path to local checks
camsteffen Feb 2, 2021
89f266a
Auto merge of #6678 - TaKO8Ki:fix-typo, r=flip1995
bors Feb 5, 2021
a507c27
Auto merge of #6679 - flip1995:ra_setup_abs_path, r=Manishearth
bors Feb 5, 2021
eb9c669
First version of the lint
1c3t3a Dec 20, 2020
f907986
Added documentation
1c3t3a Dec 21, 2020
55bfaa1
Fixed macro edge case for `semicolon_if_nothing_returned lint`
1c3t3a Feb 5, 2021
ac5e9c8
Fix let_underscore_drop implements Drop logic
camsteffen Feb 5, 2021
a9ad492
Bump clippy version
Mark-Simulacrum Feb 5, 2021
93daf27
tests: ignore check_that_clippy_has_the_same_major_version_as_rustc()…
matthiaskrgr Feb 5, 2021
a60c143
Add new lint `filter_map_identity`
magurotuna Feb 3, 2021
fbe436b
Use flatten instead of filter_map
magurotuna Feb 6, 2021
cb30219
lintcheck: update logs
matthiaskrgr Feb 6, 2021
64982cc
lintcheck: make TomlCrate also accept git-data from lintcheck_crates.…
matthiaskrgr Feb 5, 2021
10fbafa
implement the download_and_extract() step for git sources
matthiaskrgr Feb 6, 2021
9ab505a
lintcheck: add git source as an example and update logs
matthiaskrgr Feb 6, 2021
e1c284b
lintcheck: cleanup, fix --only for git crates, better error msgs
matthiaskrgr Feb 6, 2021
6626295
Fixed for loop problem, corrected all occurences that got linted
1c3t3a Feb 6, 2021
dfb34c0
Auto merge of #6684 - matthiaskrgr:versiontest_dont_break_upstream, r…
bors Feb 6, 2021
cd67487
Revert "Fixed for loop problem, corrected all occurences that got lin…
1c3t3a Feb 6, 2021
85c2b1e
Switched to `snippet_with_macro_callsite`
1c3t3a Feb 6, 2021
a5d442c
Rollup merge of #81680 - camsteffen:primty, r=oli-obk
jonas-schievink Feb 6, 2021
f1c1584
Changed lint level to `restriction`
1c3t3a Feb 6, 2021
915e9b8
Fix cargo_common_metadata warning on `publish = false`.
daxpedda Jan 29, 2021
d4bc7d2
Test names were flipped.
daxpedda Feb 3, 2021
f0d3fd7
Implement `_cargo_ignore_publish`.
daxpedda Feb 3, 2021
8805931
Hide clippy configuration option.
daxpedda Feb 6, 2021
f2391a5
Change clippy configuration option.
daxpedda Feb 6, 2021
8b89087
Add test for `publish = true`.
daxpedda Feb 6, 2021
cd361a5
Add back `publish = false` to the old test.
daxpedda Feb 6, 2021
e2e33b4
Pick up `clippy.toml` in `ui-cargo` tests.
daxpedda Feb 6, 2021
3c8f754
Fux `toml_unknown_key` test.
daxpedda Feb 6, 2021
ea0b832
Document condition.
daxpedda Feb 6, 2021
fd8b5fa
Confused about my own explanation.
daxpedda Feb 6, 2021
2bffbfc
lintcheck: avoid dbg!() calls
matthiaskrgr Feb 6, 2021
0585c34
Stabilize workspace wrapper.
ehuss Feb 6, 2021
6b4789d
Fixed suggestion in macro invocations
1c3t3a Feb 6, 2021
40ce056
Eat dogfood
camsteffen Feb 5, 2021
dfe08f4
Update triagebot.toml to new label names
flip1995 Feb 6, 2021
d792210
Auto merge of #6682 - camsteffen:let-underscore-ref, r=llogiq
bors Feb 7, 2021
b36d1a4
Auto merge of #6688 - rust-lang:triagebot_update, r=phansch
bors Feb 7, 2021
d51db24
Auto merge of #6660 - camsteffen:path-to-local, r=llogiq
bors Feb 7, 2021
001185d
Auto merge of #6681 - 1c3t3a:1c3t3a-issue-6467, r=xFrednet,flip1995,p…
bors Feb 7, 2021
ad9ceee
Auto merge of #6685 - magurotuna:filter_map_identity, r=phansch
bors Feb 7, 2021
83b7b16
Auto merge of #6674 - phlip9:disallowed_functions, r=llogiq
bors Feb 7, 2021
c1ce78f
Auto merge of #6686 - matthiaskrgr:lintcheck_git, r=flip1995
bors Feb 7, 2021
6f3eeac
lintcheck: add a cmdline option --crates-toml <TOML PATH> to override…
matthiaskrgr Feb 7, 2021
1c3033d
add a new lint `bytes_nth`
TaKO8Ki Feb 7, 2021
de35c29
Auto merge of #6694 - matthiaskrgr:lintcheck-cfg, r=Manishearth
bors Feb 7, 2021
fd35517
Downgrade trivial_regex to nursery
dtolnay Feb 8, 2021
4bbd7e4
Auto merge of #6696 - dtolnay-contrib:regex, r=Manishearth
bors Feb 8, 2021
1d30422
Enhance LocalUsedVisitor to check closure bodies
camsteffen Feb 3, 2021
5db48a3
Refactor out UnusedSelfVisitor
camsteffen Feb 3, 2021
37555f8
Use path_to_local_id
camsteffen Feb 8, 2021
34b373d
Rename HIR UnOp variants
osa1 Feb 9, 2021
775ce47
Rename "good first issue" back to "good-first-issue"
flip1995 Feb 9, 2021
03a0dd5
Auto merge of #6704 - rust-lang:flip1995-patch-1, r=phansch
bors Feb 9, 2021
b932587
Add better turbofish extractor
ThibsG Feb 9, 2021
03737e2
Remove rustfmt from rust-toolchain file
flip1995 Feb 9, 2021
08b4d50
Auto merge of #6709 - rust-lang:flip1995-patch-1, r=matthiaskrgr
bors Feb 9, 2021
0e371b8
Auto merge of #6698 - camsteffen:path-to-local, r=phansch
bors Feb 10, 2021
932cc08
Update clippy_lints/src/methods/bytes_nth.rs
TaKO8Ki Feb 10, 2021
5996ae1
add some test cases
TaKO8Ki Feb 10, 2021
9c0ae2a
Auto merge of #6687 - ehuss:stabilize-wrapper, r=flip1995
bors Feb 10, 2021
b5e4389
Auto merge of #6695 - TaKO8Ki:add-bytes-nth, r=phansch
bors Feb 10, 2021
94b8f23
Fix typo
alpaca-tc Feb 10, 2021
a6d6b1b
Auto merge of #6714 - alpaca-tc:fixed_tiny_typo, r=flip1995
bors Feb 10, 2021
3784cdf
Auto merge of #6657 - ThibsG:FromIterParens, r=llogiq
bors Feb 10, 2021
beb49ba
Auto merge of #6650 - daxpedda:cargo-common-metadata-publish, r=flip1995
bors Feb 11, 2021
1025cd3
lintcheck toml: explain why tokei is commented out
matthiaskrgr Feb 9, 2021
c7241b6
lintcheck: make the log file be ${source-file}-logs.txt
matthiaskrgr Feb 9, 2021
cfe154b
start a clippy-dev readme and some rough info on how to use lintcheck
matthiaskrgr Feb 9, 2021
5e29aa6
lintcheck: add support for path sources
matthiaskrgr Feb 10, 2021
a6d493d
lintcheck: collect ICEs
matthiaskrgr Feb 10, 2021
8dbcffe
Auto merge of #6708 - matthiaskrgr:lintcheck, r=flip1995
bors Feb 11, 2021
00f9981
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Feb 11, 2021
4efc454
Bump nightly version -> 2021-02-11
flip1995 Feb 11, 2021
70c0f90
Auto merge of #6718 - flip1995:rustup, r=flip1995
bors Feb 11, 2021
d2e2f64
Merge commit '70c0f90453701e7d6d9b99aaa1fc6a765937b736' into clippyup
flip1995 Feb 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lintcheck: add git source as an example and update logs
  • Loading branch information
matthiaskrgr committed Feb 6, 2021
commit 9ab505a3c779c7ad9b078d7d24ace4e3b05d7f1e
1 change: 1 addition & 0 deletions clippy_dev/lintcheck_crates.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ bitflags = {name = "bitflags", versions = ['1.2.1']}
libc = {name = "libc", versions = ['0.2.81']}
log = {name = "log", versions = ['0.4.11']}
proc-macro2 = {name = "proc-macro2", versions = ['1.0.24']}
puffin = {name = "puffin", git_url = "https://github.com/EmbarkStudios/puffin", git_hash = "02dd4a3"}
quote = {name = "quote", versions = ['1.0.7']}
rand = {name = "rand", versions = ['0.7.3']}
rand_core = {name = "rand_core", versions = ['0.6.0']}
Expand Down
1 change: 1 addition & 0 deletions clippy_dev/src/lintcheck.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ impl CrateSource {
};
// clone the repo if we have not done so
if !repo_path.is_dir() {
println!("Cloning {} and checking out {}", url, commit);
Command::new("git")
.arg("clone")
.arg(url)
Expand Down
82 changes: 69 additions & 13 deletions lintcheck-logs/logs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2086,6 +2086,61 @@ proc-macro2-1.0.24/src/parse.rs:808:15 clippy::explicit_iter_loop "it is more co
proc-macro2-1.0.24/src/wrapper.rs:415:24 clippy::trivially_copy_pass_by_ref "this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)"
proc-macro2-1.0.24/src/wrapper.rs:429:23 clippy::trivially_copy_pass_by_ref "this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)"
proc-macro2-1.0.24/src/wrapper.rs:492:17 clippy::trivially_copy_pass_by_ref "this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:158:15 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:175:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin-imgui/src/ui.rs:183:5 clippy::too_many_lines "this function has too many lines (115/100)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:1:5 clippy::wildcard_imports "usage of wildcard import"
puffin-02dd4a3/puffin-imgui/src/ui.rs:207:16 clippy::collapsible_else_if "this `else { if .. }` block can be collapsed"
puffin-02dd4a3/puffin-imgui/src/ui.rs:271:67 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:2:5 clippy::wildcard_imports "usage of wildcard import"
puffin-02dd4a3/puffin-imgui/src/ui.rs:376:29 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:381:44 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:453:9 clippy::similar_names "binding's name is too similar to existing binding"
puffin-02dd4a3/puffin-imgui/src/ui.rs:540:14 clippy::cast_possible_truncation "casting `f64` to `f32` may truncate the value"
puffin-02dd4a3/puffin-imgui/src/ui.rs:551:5 clippy::cast_precision_loss "casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:584:39 clippy::cast_precision_loss "casting `usize` to `f32` causes a loss of precision (`usize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:59:26 clippy::unsafe_derive_deserialize "you are deriving `serde::Deserialize` on a type that has methods using `unsafe`"
puffin-02dd4a3/puffin-imgui/src/ui.rs:61:1 clippy::module_name_repetitions "item name ends with its containing module's name"
puffin-02dd4a3/puffin-imgui/src/ui.rs:627:39 clippy::cast_precision_loss "casting `usize` to `f32` causes a loss of precision (`usize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:674:47 clippy::cast_precision_loss "casting `usize` to `f64` causes a loss of precision on targets with 64-bit wide pointers (`usize` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)"
puffin-02dd4a3/puffin-imgui/src/ui.rs:690:9 clippy::cast_precision_loss "casting `usize` to `f32` causes a loss of precision (`usize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
puffin-02dd4a3/puffin/src/data.rs:102:25 clippy::cast_possible_truncation "casting `usize` to `u8` may truncate the value"
puffin-02dd4a3/puffin/src/data.rs:112:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/data.rs:116:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
puffin-02dd4a3/puffin/src/data.rs:137:24 clippy::match_same_arms "this `match` has identical arm bodies"
puffin-02dd4a3/puffin/src/data.rs:177:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
puffin-02dd4a3/puffin/src/data.rs:211:21 clippy::cast_possible_truncation "casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers"
puffin-02dd4a3/puffin/src/data.rs:24:5 clippy::wildcard_imports "usage of wildcard import"
puffin-02dd4a3/puffin/src/data.rs:75:5 clippy::missing_panics_doc "docs for function which may panic missing `# Panics` section"
puffin-02dd4a3/puffin/src/lib.rs:113:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:147:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
puffin-02dd4a3/puffin/src/lib.rs:147:5 clippy::missing_panics_doc "docs for function which may panic missing `# Panics` section"
puffin-02dd4a3/puffin/src/lib.rs:165:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
puffin-02dd4a3/puffin/src/lib.rs:200:21 clippy::default_trait_access "calling `Stream::default()` is more clear than this expression"
puffin-02dd4a3/puffin/src/lib.rs:257:78 clippy::default_trait_access "calling `std::cell::RefCell::default()` is more clear than this expression"
puffin-02dd4a3/puffin/src/lib.rs:297:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:302:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:308:28 clippy::default_trait_access "calling `FullProfileData::default()` is more clear than this expression"
puffin-02dd4a3/puffin/src/lib.rs:316:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:321:5 clippy::cast_possible_truncation "casting `u128` to `i64` may truncate the value"
puffin-02dd4a3/puffin/src/lib.rs:348:28 clippy::default_trait_access "calling `std::marker::PhantomData::default()` is more clear than this expression"
puffin-02dd4a3/puffin/src/lib.rs:359:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:375:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:376:5 clippy::option_if_let_else "use Option::map_or instead of an if let/else"
puffin-02dd4a3/puffin/src/lib.rs:377:9 clippy::option_if_let_else "use Option::map_or instead of an if let/else"
puffin-02dd4a3/puffin/src/lib.rs:406:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:408:5 clippy::option_if_let_else "use Option::map_or instead of an if let/else"
puffin-02dd4a3/puffin/src/lib.rs:69:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:73:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/lib.rs:77:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/merge.rs:21:1 clippy::module_name_repetitions "item name starts with its containing module's name"
puffin-02dd4a3/puffin/src/merge.rs:28:1 clippy::module_name_repetitions "item name starts with its containing module's name"
puffin-02dd4a3/puffin/src/merge.rs:28:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
puffin-02dd4a3/puffin/src/merge.rs:35:1 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
puffin-02dd4a3/puffin/src/merge.rs:35:1 clippy::module_name_repetitions "item name starts with its containing module's name"
puffin-02dd4a3/puffin/src/merge.rs:64:43 clippy::default_trait_access "calling `std::vec::Vec::default()` is more clear than this expression"
puffin-02dd4a3/puffin/src/merge.rs:65:54 clippy::default_trait_access "calling `std::collections::HashMap::default()` is more clear than this expression"
puffin-02dd4a3/puffin/src/merge.rs:9:1 clippy::module_name_repetitions "item name starts with its containing module's name"
quote-1.0.7/src/ext.rs:10:1 clippy::module_name_repetitions "item name ends with its containing module's name"
quote-1.0.7/src/ext.rs:7:5 clippy::doc_markdown "you should put `TokenStream` between ticks in the documentation"
quote-1.0.7/src/ident_fragment.rs:13:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
Expand Down Expand Up @@ -3383,6 +3438,7 @@ clippy::should_implement_trait 1
clippy::stable_sort_primitive 1
clippy::unit_arg 1
clippy::unnecessary_lazy_evaluations 1
clippy::unsafe_derive_deserialize 1
clippy::used_underscore_binding 1
clippy::verbose_bit_mask 1
clippy::while_let_on_iterator 1
Expand Down Expand Up @@ -3410,7 +3466,6 @@ clippy::ptr_arg 3
clippy::zero_ptr 3
clippy::let_underscore_drop 4
clippy::too_many_arguments 4
clippy::collapsible_else_if 5
clippy::explicit_iter_loop 5
clippy::field_reassign_with_default 5
clippy::identity_op 5
Expand All @@ -3419,6 +3474,7 @@ clippy::match_like_matches_macro 5
clippy::needless_return 5
clippy::new_without_default 5
clippy::ptr_as_ptr 5
clippy::collapsible_else_if 6
clippy::manual_strip 6
clippy::non_ascii_literal 6
clippy::single_component_path_imports 6
Expand All @@ -3436,12 +3492,11 @@ clippy::missing_safety_doc 10
clippy::needless_doctest_main 10
clippy::multiple_crate_versions 11
clippy::needless_lifetimes 12
clippy::option_if_let_else 12
clippy::cargo_common_metadata 13
clippy::shadow_unrelated 13
clippy::linkedlist 14
clippy::single_char_add_str 14
clippy::default_trait_access 16
clippy::option_if_let_else 15
clippy::needless_pass_by_value 18
clippy::upper_case_acronyms 18
clippy::cast_possible_wrap 19
Expand All @@ -3452,26 +3507,27 @@ clippy::unusual_byte_groupings 19
clippy::map_unwrap_or 20
clippy::struct_excessive_bools 20
clippy::redundant_static_lifetimes 21
clippy::default_trait_access 22
clippy::cast_lossless 23
clippy::trivially_copy_pass_by_ref 26
clippy::redundant_else 29
clippy::too_many_lines 31
clippy::cast_precision_loss 35
clippy::too_many_lines 32
clippy::if_not_else 35
clippy::enum_glob_use 40
clippy::unseparated_literal_suffix 41
clippy::cast_precision_loss 44
clippy::single_match_else 45
clippy::inline_always 59
clippy::match_same_arms 64
clippy::similar_names 77
clippy::cast_possible_truncation 91
clippy::missing_panics_doc 106
clippy::match_same_arms 65
clippy::similar_names 78
clippy::cast_possible_truncation 95
clippy::missing_panics_doc 108
clippy::redundant_field_names 111
clippy::redundant_closure_for_method_calls 135
clippy::module_name_repetitions 137
clippy::items_after_statements 139
clippy::wildcard_imports 160
clippy::module_name_repetitions 142
clippy::wildcard_imports 163
clippy::doc_markdown 178
clippy::missing_errors_doc 338
clippy::missing_errors_doc 343
clippy::unreadable_literal 365
clippy::must_use_candidate 552
clippy::must_use_candidate 565