Skip to content

Properly check target_features not to trigger an assertion #89937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Oct 27, 2021
Merged

Properly check target_features not to trigger an assertion #89937

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5cbb9b
Fix some typos
JohnTitor Oct 16, 2021
630df7c
Remove unnecessary check for registers
JohnTitor Oct 19, 2021
bd309e4
Add a regression test for issue-89875
JohnTitor Oct 19, 2021
12647ea
Properly check `target_features` not to trigger an assertion
JohnTitor Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary check for registers 
`is_clobber()` already checks if `reg` is a register and the both
values should be the same.
  • Loading branch information
@JohnTitor
JohnTitor committed Oct 26, 2021
commit 630df7c54ab1b6d227893aae98bfdbf77228e637
4 changes: 1 addition & 3 deletions compiler/rustc_ast_lowering/src/asm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
// means that we disallow passing a value in/out of the asm and
// require that the operand name an explicit register, not a
// register class.
if reg_class.is_clobber_only(asm_arch.unwrap())
&& !(op.is_clobber() && matches!(reg, asm::InlineAsmRegOrRegClass::Reg(_)))
{
if reg_class.is_clobber_only(asm_arch.unwrap()) && !op.is_clobber() {
let msg = format!(
"register class `{}` can only be used as a clobber, \
not as an input or output",
Expand Down