Skip to content

Replace Linux Mutex and Condvar with futex based ones. #95035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 14 commits into from
Apr 5, 2022
+251 −41
Merged

Replace Linux Mutex and Condvar with futex based ones. #95035

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4fbd71c
Return timeout status in futex_wait.
m-ou-se Mar 17, 2022
73d6348
Add futex_wake_all.
m-ou-se Mar 17, 2022
7f26ade
Replace Linux Mutex and Condvar with futex based ones.
m-ou-se Mar 17, 2022
10b6f33
Update tests.
m-ou-se Mar 17, 2022
da4ef04
Spin before blocking in Mutex::lock.
m-ou-se Mar 21, 2022
8729929
Use FUTEX_WAIT_BITSET rather than FUTEX_WAIT on Linux.
m-ou-se Mar 24, 2022
23badeb
Make Timespec available in sys::unix.
m-ou-se Mar 24, 2022
c9ae3fe
Explicitly use CLOCK_MONOTONIC in futex_wait.
m-ou-se Mar 24, 2022
c49887d
Add comment about futex_wait timeout.
m-ou-se Apr 1, 2022
6392f15
Shuffle around #[inline] and #[cold] in mutex impl.
m-ou-se Apr 1, 2022
321690c
Don't spin on contended mutexes.
m-ou-se Apr 1, 2022
4b1b305
Use MaybeUninit for clock_gettime's timespec.
m-ou-se Apr 1, 2022
104e95f
Mark unix::locks::futex::Mutex::new as #[inline].
m-ou-se Apr 5, 2022
650315e
Reword comment in futex condvar implementation.
m-ou-se Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests.
  • Loading branch information
@m-ou-se
m-ou-se committed Mar 23, 2022
commit 10b6f3350820f05ab7aed5c9e2cf30bc34663668
2 changes: 1 addition & 1 deletion library/std/src/sync/condvar/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ fn wait_timeout_wake() {

#[test]
#[should_panic]
#[cfg_attr(not(unix), ignore)]
#[cfg(all(unix, not(target_os = "linux"), not(target_os = "android")))]
fn two_mutexes() {
let m = Arc::new(Mutex::new(()));
let m2 = m.clone();
Expand Down