Replace sort_modules_alphabetically boolean with enum
#98685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the long-standing FIXME there and makes the code easier to understand. The reference to modules in both the old and new names seems potentially wrong since I believe it applies to all items.
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jun 29, 2022
|
Thanks! The code is indeed much better. :) r=me (with rollup) once CI pass. |
|
@bors r=GuillaumeGomez rollup |
|
📌 Commit be0b112 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 29, 2022
Replace `sort_modules_alphabetically` boolean with enum This fixes the long-standing FIXME there and makes the code easier to understand. The reference to modules in both the old and new names seems potentially wrong since I believe it applies to all items. r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 30, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#96727 (Make TAIT behave exactly like RPIT) - rust-lang#98681 (rustdoc-json: Make default value of blanket impl assoc types work) - rust-lang#98682 (add tests for ICE 94432) - rust-lang#98683 (add test for ice 68875) - rust-lang#98685 (Replace `sort_modules_alphabetically` boolean with enum) - rust-lang#98687 (add test for 47814) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long-standing FIXME there and makes the code easier to
understand. The reference to modules in both the old and new names seems
potentially wrong since I believe it applies to all items.
r? @GuillaumeGomez