Skip to content

Add 2025-09-23 triage #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add 2025-09-23 triage #2256

wants to merge 2 commits into from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Sep 23, 2025

@klensy
Copy link
Contributor

klensy commented Sep 23, 2025

Small binary size regression in 146666 in crate_metadata/linked_artifact

@Kobzol
Copy link
Member Author

Kobzol commented Sep 23, 2025

Thanks, I missed that one. I don't think that there's much to do though, the regression is small and I doubt we'd want to revert any PR based on that.

@klensy
Copy link
Contributor

klensy commented Sep 23, 2025

Yes, revert is too heavy tool, but in case pr is known, author can probably fix it, if it not difficult.

panstromek
panstromek reviewed Sep 23, 2025
View reviewed changes
panstromek
panstromek approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@panstromek panstromek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I can't check the grammar, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panstromek panstromek panstromek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kobzol @klensy @panstromek