GitHub actions #2190
GitHub actions #2190
Conversation
With the switch away from Travis to Github actions, the scripts we use for CI have to be updated. Signed-off-by: Daniel Silverstone <[email protected]>
These templates are for Github Actions Workflows and will be processed by a script for use. Do not edit workflows in .github/workflows but rather edit these templates and then run the script. Signed-off-by: Daniel Silverstone <[email protected]>
In order to cope with our current release process, these workflows have to be generated by scripting. If you need to change the workflows edit the YAML alongside this script and then run the script to regenerate the .github/workflows files. Signed-off-by: Daniel Silverstone <[email protected]>
This completes the initial transition to Github Actions by removing appveyor and travis configurations and the last vestiges of mentions of it in the ci tree. Signed-off-by: Daniel Silverstone <[email protected]>
These are the workflows generated by running: sh ci/actions-templates/gen-workflows.sh Signed-off-by: Daniel Silverstone <[email protected]>
| jobs: | ||
| check: | ||
| name: Checks | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
The name and file name claims to check on centos. This metadata says it checks on ubuntu. I think that this is confusing.
There was a problem hiding this comment.
Or if it does check on centos a comment would help
There was a problem hiding this comment.
The centos check is done in a docker in one of the actions. fmt, clippy, and shellcheck are not done on centos.
There was a problem hiding this comment.
If you want to patch the texts to make things nicer, please file a PR, this was the culmination of two days of frustration, so it's not the prettiest it could be yet :D
There was a problem hiding this comment.
I'm not entirely sure I understand it all yet. What is a 'centos check' vs say a shellcheck run on centos?
There was a problem hiding this comment.
the centos check is the docker run where we validate that rustup-init.sh still works on centos 6 which is the oldest platform (oldest curl etc) which we support.
2 participants
This PR introduces github actions for everything and removes the travis and appveyor configurations.
It needs careful checking to ensure everything is right.