fix(install): default to GNU host in Cygwin/MSYS/MinGW environments (#4421) #4497
Conversation
rustup-init.sh
Outdated
| esac | ||
| done | ||
| if [ "$_has_default_host_arg" = false ]; then | ||
| set -- "$@" --default-host x86_64-pc-windows-gnu |
There was a problem hiding this comment.
Should we consider the possibility of aarch64-pc-windows-gnullvm as well? It's a tier 2 target for now.
cc @ChrisDenton
There was a problem hiding this comment.
Hm... for arm we should probably not touch the default for now, at least until support for gnu on the target is more mainstream. The gnullvm target was only fairly recently promoted to having host tooling and iirc requires installing llvm tools (instead of gnu ones). We could revisit this in the future.
rustup-init.sh
Outdated
| ignore "$_file" "$@" < /dev/tty | ||
| else | ||
| # Default to GNU toolchain under Cygwin/MSYS/MinGW environments | ||
| case "$(uname -s)" in |
There was a problem hiding this comment.
You should move whatever default host detection logic you may have into the get_architecture() function, otherwise it might break the RUSTUP_INIT_SH_PRINT=arch functionality.
cachebag
changed the title
cachebag
force-pushed
the
cygwin-default-host
branch
2 times, most recently
from
192531b to
a051ee1
Compare
@rami3l |
cachebag
force-pushed
the
cygwin-default-host
branch
2 times, most recently
from
950e61d to
072ba3f
Compare
cachebag
force-pushed
the
cygwin-default-host
branch
from
072ba3f to
f3ccd26
Compare
Addresses first mentioned issue in #4421, modifying the install script to default to
x86_64-pc-windows-gnuunder Cygwin/MSYS when no --default-host is provided.The second issue requires changes in the compiled rustup-init binary (src/), which is out of scope for now