Skip to content

Fix AudioError parsing for functions that return size. #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JelliiDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AudioError parsing for functions that return size. #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed error parsing for functions that return size.
  • Loading branch information
@JelliiDev
JelliiDev committed Dec 13, 2025
commit adf52c51a338f26b309918ba14b5d3d4d7b055a6
9 changes: 5 additions & 4 deletions ndk/src/audio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,14 +479,15 @@ impl AudioError {
ptr.to_string_lossy()
}

/// Returns [`Ok`] on [`ffi::AAUDIO_OK`], [`Err`] otherwise (including positive values).
/// Returns [`Ok`] on [`ffi::AAUDIO_OK`] or any positive value, for example, size, [`Err`] otherwise.
///
/// Note that some known error codes (currently only for `AMediaCodec`) are positive.
pub(crate) fn from_result(status: ffi::aaudio_result_t) -> Result<()> {
match status {
ffi::AAUDIO_OK => Ok(()),
x => Err(Self::from(x)),
if status >= ffi::AAUDIO_OK {
return Ok(())
}

Err(Self::from(status))
}
}

Expand Down