Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add benchmark for reserve()
  • Loading branch information
ssande7 authored and bluss committed Apr 6, 2024
commit aa077bf56f06bdedf1bace7aa0fe173afc043c0c
31 changes: 31 additions & 0 deletions benches/reserve.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#![feature(test)]

extern crate test;
use test::Bencher;

use ndarray::prelude::*;

#[bench]
fn push_reserve(bench: &mut Bencher)
{
let ones: Array<f32, _> = array![1f32];
bench.iter(|| {
let mut a: Array<f32, Ix1> = array![];
a.reserve(Axis(0), 100);
for _ in 0..100 {
a.append(Axis(0), ones.view()).unwrap();
}
});
}

#[bench]
fn push_no_reserve(bench: &mut Bencher)
{
let ones: Array<f32, _> = array![1f32];
bench.iter(|| {
let mut a: Array<f32, Ix1> = array![];
for _ in 0..100 {
a.append(Axis(0), ones.view()).unwrap();
}
});
}
3 changes: 0 additions & 3 deletions src/impl_owned_array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -764,9 +764,6 @@ where D: Dimension
pub fn reserve(&mut self, axis: Axis, additional: usize)
where D: RemoveAxis
{
if additional == 0 {
return;
}
let self_dim = self.raw_dim();
let remaining_shape = self_dim.remove_axis(axis);
let len_to_append = remaining_shape.size() * additional;
Expand Down