Skip to content

Use clone_from() in two places #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

Use clone_from() in two places #1347

merged 1 commit into from
Jan 12, 2024

Conversation

@ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Jan 7, 2024

In fill() and in assign().

@ChayimFriedman2
Use clone_from() in two places
7b8d031 
In `fill()` and in `assign()`.
@adamreichold
Copy link
Collaborator

adamreichold commented Jan 7, 2024

Let's see if this compatible with the current MSRV.

@ChayimFriedman2
Copy link
Contributor Author

ChayimFriedman2 commented Jan 7, 2024

clone_from() is there since v1 of Rust.

@adamreichold adamreichold merged commit 4374a9c into rust-ndarray:master Jan 12, 2024
@ChayimFriedman2 ChayimFriedman2 deleted the clone_from branch January 13, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChayimFriedman2 @adamreichold