Skip to content

Adding fused div_add #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulXiCao wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Adding fused div_add #149

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c127d65
div_add
PaulXiCao Oct 17, 2025
4b11856
div_add_ref
PaulXiCao Oct 17, 2025
13b7a02
overloaded div_add via DivAdd trait
PaulXiCao Oct 17, 2025
fba3b58
elide explicit lifetimes
PaulXiCao Oct 17, 2025
fc1a767
add tests
PaulXiCao Oct 17, 2025
49503f0
simplify div_add impl: use Div, Add
PaulXiCao Oct 25, 2025
e8ce020
test ref impl of div_add
PaulXiCao Oct 25, 2025
4376f8e
specify trait bound `Mul`
PaulXiCao Oct 25, 2025
ccec572
DivAdd trait pub visibility
PaulXiCao Oct 25, 2025
90da11d
cleanup usages in test module
PaulXiCao Oct 25, 2025
1a0ab93
move trait bounds into where clause
PaulXiCao Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify div_add impl: use Div, Add
  • Loading branch information
@PaulXiCao
PaulXiCao committed Oct 25, 2025
commit 49503f01f076b0612c528f8808da9be915b12658
13 changes: 5 additions & 8 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,9 +830,7 @@ trait DivAdd<Rhs = Self, Addend = Self> {
}

// (a + i b) / (c + i d) + (e + i f) == [(a + i b) * (c - i d)] / (c*c + d*d) + (e + i f)
// == [(a + i b) * (c - i d) + (c*c + d*d) * (e + i f)] / n for n=(c*c + d*d)
// == [(a*c + b*d + n*e) + i (-a*d + b*c + n*f)] / n
// == [{(a*c + b*d) / n + e} + i {(-a*d + b*c) / n + f}]
// == {(a*c + b*d) + i (-a*d + b*c)} / n + (e + i f) for n=(c*c + d*d)
impl<T: Clone + Num + MulAdd<Output = T> + Neg<Output = T>> DivAdd<Complex<T>> for Complex<T> {
type Output = Self;

Expand All @@ -841,12 +839,11 @@ impl<T: Clone + Num + MulAdd<Output = T> + Neg<Output = T>> DivAdd<Complex<T>> f
let n = other.norm_sqr();
let (a, b) = (self.re, self.im);
let (c, d) = (other.re, other.im);
let (e, f) = (add.re, add.im);

let re = a.clone().mul_add(c.clone(), b.clone() * d.clone());
let im = a.mul_add(-d, b * c);

let re = a.clone().mul_add(c.clone(), b.clone() * d.clone()) / n.clone() + e;
let im = a.mul_add(-d, b * c) / n + f;

Self::new(re, im)
Self::new(re, im) / n + add
}
}
impl<T: Clone + Num + MulAdd<Output = T> + Neg<Output = T>> DivAdd<&Complex<T>> for &Complex<T> {
Expand Down