Skip to content

Simplify trait BlockRngCore and rename to Generator #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhardy merged 9 commits into from
Dec 5, 2025
Merged

Simplify trait BlockRngCore and rename to Generator #26

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
01d4237
Simplify trait BlockRngCore: remove assoc. type Item
dhardy Nov 17, 2025
e34c1f3
Allow *any* unused code in doc tests
dhardy Nov 17, 2025
977f74e
Rename BlockRngCore -> Generator
dhardy Nov 17, 2025
ed22701
Rename Generator::Results -> Output
dhardy Nov 30, 2025
5f59956
Rename R -> G: Generator
dhardy Nov 30, 2025
84c23d8
BlockRng: remove bound on <G as Generator>::Output in Debug impl
dhardy Nov 30, 2025
fdf3885
Remove unnecessary calls to as_ref / as_mut
dhardy Dec 1, 2025
49ff793
Replace usages of results.len() with N
dhardy Dec 1, 2025
3777037
Update CHANGELOG
dhardy Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BlockRng: remove bound on <G as Generator>::Output in Debug impl
  • Loading branch information
@dhardy
dhardy committed Nov 30, 2025
commit 84c23d885c7999241de5673e7f816ca6b198e3d1
6 changes: 2 additions & 4 deletions src/block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,10 @@ pub struct BlockRng<G: Generator> {
}

// Custom Debug implementation that does not expose the contents of `results`.
impl<const N: usize, G: Generator<Output = [u32; N]> + fmt::Debug> fmt::Debug for BlockRng<G> {
impl<G: Generator + fmt::Debug> fmt::Debug for BlockRng<G> {
fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
fmt.debug_struct("BlockRng")
.field("core", &self.core)
.field("result_len", &self.results.as_ref().len())
.field("index", &self.index)
.finish()
}
Expand Down Expand Up @@ -273,11 +272,10 @@ pub struct BlockRng64<G: Generator + ?Sized> {
}

// Custom Debug implementation that does not expose the contents of `results`.
impl<const N: usize, G: Generator<Output = [u64; N]> + fmt::Debug> fmt::Debug for BlockRng64<G> {
impl<G: Generator + fmt::Debug> fmt::Debug for BlockRng64<G> {
fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
fmt.debug_struct("BlockRng64")
.field("core", &self.core)
.field("result_len", &self.results.as_ref().len())
.field("index", &self.index)
.field("half_used", &self.half_used)
.finish()
Expand Down