Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2024

Bumps the vhost-device group in /staging with 16 updates:

Package From To
nix 0.26.4 0.27.1
indexmap 2.4.0 2.5.0
proc-macro-crate 3.1.0 3.2.0
rustc_version 0.4.0 0.4.1
rustix 0.38.34 0.38.35
toml_edit 0.21.1 0.22.20
windows-sys 0.52.0 0.48.0
windows-targets 0.52.6 0.48.5
windows_aarch64_gnullvm 0.52.6 0.48.5
windows_aarch64_msvc 0.52.6 0.48.5
windows_i686_gnu 0.52.6 0.48.5
windows_i686_msvc 0.52.6 0.48.5
windows_x86_64_gnu 0.52.6 0.48.5
windows_x86_64_gnullvm 0.52.6 0.48.5
windows_x86_64_msvc 0.52.6 0.48.5
winnow 0.5.40 0.6.18

Updates nix from 0.26.4 to 0.27.1

Changelog

Sourced from nix's changelog.

[0.27.1] - 2023-08-28

Fixed

  • Fixed generating the documentation on docs.rs. (#2111)

[0.27.0] - 2023-08-28

Added

  • Added AT_EACCESS to AtFlags on all platforms but android (#1995)
  • Add PF_ROUTE to SockType on macOS, iOS, all of the BSDs, Fuchsia, Haiku, Illumos. (#1867)
  • Added nix::ucontext module on aarch64-unknown-linux-gnu. (#1662)
  • Added CanRaw to SockProtocol and CanBcm as a separate SocProtocol constant. (#1912)
  • Added Generic and NFLOG to SockProtocol. (#2092)
  • Added mq_timedreceive to ::nix::mqueue. (#1966)(nix-rust/nix#1966)
  • Added LocalPeerPid to nix::sys::socket::sockopt for macOS. (#1967)
  • Added TFD_TIMER_CANCEL_ON_SET to ::nix::sys::time::TimerSetTimeFlags on Linux and Android. (#2040)
  • Added SOF_TIMESTAMPING_OPT_ID and SOF_TIMESTAMPING_OPT_TSONLY to nix::sys::socket::TimestampingFlag. (#2048)
  • Enabled socket timestamping options on Android. (#2077)
  • Added vsock support for macOS (#2056)
  • Added SO_SETFIB and SO_USER_COOKIE to nix::sys::socket::sockopt for FreeBSD. (#2085)
  • Added SO_RTABLE for OpenBSD and SO_ACCEPTFILTER for FreeBSD/NetBSD to nix::sys::socket::sockopt. (#2085)
  • Added MSG_WAITFORONE to MsgFlags on Android, Fuchsia, Linux, NetBSD, FreeBSD, OpenBSD, and Solaris. (#2014)
  • Added SO_TS_CLOCK for FreeBSD to nix::sys::socket::sockopt. (#2093)
  • Added support for prctl in Linux. (#1550)
  • nix::socket and nix::select are now available on Redox. (#2012)
  • Implemented AsFd, AsRawFd, FromRawFd, and IntoRawFd for mqueue::MqdT. (#2097)
  • Add the ability to set kevent_flags on SigEvent. (#1731)

Changed

  • All Cargo features have been removed from the default set. Users will need to specify which features they depend on in their Cargo.toml.

... (truncated)

Commits

Updates indexmap from 2.4.0 to 2.5.0

Changelog

Sourced from indexmap's changelog.

2.5.0

  • Added an insert_before method to IndexMap and IndexSet, as an alternative to shift_insert with different behavior on existing entries.
  • Added first_entry and last_entry methods to IndexMap.
  • Added From implementations between IndexedEntry and OccupiedEntry.
Commits
  • 48ed490 Release 2.5.0
  • 139d7ad Merge pull request #340 from cuviper/insert-bounds
  • 1d9b5e3 Add doc examples for insert_before and shift_insert
  • 8ca01b0 Use insert_before for "new" entries in insert_sorted
  • 7224def Add insert_before as an alternate to shift_insert
  • 0247a15 Document and assert index bounds in shift_insert
  • 922c6ad Update the CI badge
  • e482e17 Merge pull request #342 from cuviper/btree-like
  • b63e4a1 Merge pull request #341 from cuviper/from-entry
  • 264e5b7 Add doc aliases like BTreeMap/BTreeSet
  • Additional commits viewable in compare view

Updates proc-macro-crate from 3.1.0 to 3.2.0

Release notes

Sourced from proc-macro-crate's releases.

v3.2.0

What's Changed

Full Changelog: bkchr/proc-macro-crate@v3.0.1...v3.2.0

Commits

Updates rustc_version from 0.4.0 to 0.4.1

Release notes

Sourced from rustc_version's releases.

0.4.1

What's Changed

Commits
  • eeca449 Set rust-version in metadata
  • a47da65 Remove authors from metadata (per RFC 3052)
  • b4b6dbb Update cargo-deny config
  • 3997cc6 Make license metadata SPDX compatible
  • 75d6f4a bump version number: v0.4.1
  • 7e78539 respect RUSTC_WRAPPER env var
  • 599b9e9 Add funding options
  • 9cdb266 Update URLs after repo transfer
  • See full diff in compare view

Updates rustix from 0.38.34 to 0.38.35

Commits
  • 629de02 chore: Release rustix version 0.38.35
  • c4c4511 Miscellaneous documentation fixes. (#1142)
  • b978851 Fix elided_lifetimes_in_paths warnings. (#1141)
  • 5ee37f5 Disable the futex deprecation for now. (#1138)
  • e8bcc80 Add more documentation for inotify. (#1140)
  • 3bf3410 Add inotify:: qualifiers to the inotify deprecation messages. (#1136)
  • 547fbe7 Add a module-level example comment to the shm module. (#1137)
  • 8da70cb Miscellaneous documentation and clippy fixes for epoll. (#1135)
  • e2014c5 Miscellaneous documentation and clippy fixes for futex. (#1134)
  • d0c4b8f Add more epoll:: qualifiers to epoll's public API. (#1132)
  • Additional commits viewable in compare view

Updates toml_edit from 0.21.1 to 0.22.20

Commits

Updates windows-sys from 0.52.0 to 0.48.0

Commits

Updates windows-targets from 0.52.6 to 0.48.5

Commits

Updates windows_aarch64_gnullvm from 0.52.6 to 0.48.5

Commits

Updates windows_aarch64_msvc from 0.52.6 to 0.48.5

Commits

Updates windows_i686_gnu from 0.52.6 to 0.48.5

Commits

Updates windows_i686_msvc from 0.52.6 to 0.48.5

Commits

Updates windows_x86_64_gnu from 0.52.6 to 0.48.5

Commits

Updates windows_x86_64_gnullvm from 0.52.6 to 0.48.5

Commits

Updates windows_x86_64_msvc from 0.52.6 to 0.48.5

Commits

Updates winnow from 0.5.40 to 0.6.18

Changelog

Sourced from winnow's changelog.

[0.6.18] - 2024-07-31

[0.6.17] - 2024-07-31

Features

  • Make Checkpoints comparable

[0.6.16] - 2024-07-25

[0.6.15] - 2024-07-22

Compatibility

  • Deprecated Parser::recognize in favor of Parser::take
  • Deprecated Parser::with_recognized in favor of Parser::taken

Fixes

  • Renamed Parser::recognize to Parser::take to be consistent with other take parsers
  • Renamed Parser::with_recognized to Parser::with_taken to be consistent with other take parsers

[0.6.14] - 2024-07-19

Fixes

  • Removed unused I: Clone bound on Parser::parse

[0.6.13] - 2024-06-06

Documentation

  • Expand on error reporting

[0.6.12] - 2024-06-06

Fixes

  • Improve compilation errors when using non-parsers with seq! struct syntax

[0.6.11] - 2024-06-03

Fixes

  • Remove AsBytes bounds, unblocking parsing frames of binary input

[0.6.10] - 2024-06-03

Features

... (truncated)

Commits
  • 132b280 chore: Release
  • 79eab7b perf(stream): Ensure Checkpoint operations are inlined
  • bf23cd2 chore: Release
  • 877bfb6 docs: Update changelog
  • e746a0f Merge pull request #577 from epage/ord
  • 4ff0f9c feat(stream): Make Checkpoints comparable
  • 103d9e7 Merge pull request #576 from epage/docs
  • fa65369 docs(tutorial): Be more explicit about ParseError's role
  • 67d3604 Merge pull request #574 from epage/template
  • 71049c3 refactor: Move off of deprecated code
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the vhost-device group in /staging with 16 updates:

| Package | From | To |
| --- | --- | --- |
| [nix](https://github.com/nix-rust/nix) | `0.26.4` | `0.27.1` |
| [indexmap](https://github.com/indexmap-rs/indexmap) | `2.4.0` | `2.5.0` |
| [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) | `3.1.0` | `3.2.0` |
| [rustc_version](https://github.com/djc/rustc-version-rs) | `0.4.0` | `0.4.1` |
| [rustix](https://github.com/bytecodealliance/rustix) | `0.38.34` | `0.38.35` |
| [toml_edit](https://github.com/toml-rs/toml) | `0.21.1` | `0.22.20` |
| [windows-sys](https://github.com/microsoft/windows-rs) | `0.52.0` | `0.48.0` |
| [windows-targets](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_aarch64_gnullvm](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_aarch64_msvc](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_i686_gnu](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_i686_msvc](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_x86_64_gnu](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_x86_64_gnullvm](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [windows_x86_64_msvc](https://github.com/microsoft/windows-rs) | `0.52.6` | `0.48.5` |
| [winnow](https://github.com/winnow-rs/winnow) | `0.5.40` | `0.6.18` |


Updates `nix` from 0.26.4 to 0.27.1
- [Changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md)
- [Commits](nix-rust/nix@v0.26.4...v0.27.1)

Updates `indexmap` from 2.4.0 to 2.5.0
- [Changelog](https://github.com/indexmap-rs/indexmap/blob/master/RELEASES.md)
- [Commits](indexmap-rs/indexmap@2.4.0...2.5.0)

Updates `proc-macro-crate` from 3.1.0 to 3.2.0
- [Release notes](https://github.com/bkchr/proc-macro-crate/releases)
- [Commits](https://github.com/bkchr/proc-macro-crate/commits/v3.2.0)

Updates `rustc_version` from 0.4.0 to 0.4.1
- [Release notes](https://github.com/djc/rustc-version-rs/releases)
- [Commits](djc/rustc-version-rs@v0.4.0...v0.4.1)

Updates `rustix` from 0.38.34 to 0.38.35
- [Release notes](https://github.com/bytecodealliance/rustix/releases)
- [Commits](bytecodealliance/rustix@v0.38.34...v0.38.35)

Updates `toml_edit` from 0.21.1 to 0.22.20
- [Commits](toml-rs/toml@v0.21.1...v0.22.20)

Updates `windows-sys` from 0.52.0 to 0.48.0
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.52.0...0.48.0)

Updates `windows-targets` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_aarch64_gnullvm` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_aarch64_msvc` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_i686_gnu` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_i686_msvc` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_x86_64_gnu` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_x86_64_gnullvm` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `windows_x86_64_msvc` from 0.52.6 to 0.48.5
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits/0.48.5)

Updates `winnow` from 0.5.40 to 0.6.18
- [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md)
- [Commits](winnow-rs/winnow@v0.5.40...v0.6.18)

---
updated-dependencies:
- dependency-name: nix
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: indexmap
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: proc-macro-crate
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: rustc_version
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: vhost-device
- dependency-name: rustix
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: vhost-device
- dependency-name: toml_edit
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows-sys
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows-targets
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_aarch64_gnullvm
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_aarch64_msvc
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_i686_gnu
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_i686_msvc
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_x86_64_gnu
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_x86_64_gnullvm
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: windows_x86_64_msvc
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
- dependency-name: winnow
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: vhost-device
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from stsquad as a code owner September 2, 2024 05:06
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Sep 2, 2024
@epilys
Copy link
Member

epilys commented Sep 2, 2024

Build breaks because nix removed all default features and they need to be specified explicitly now:

All Cargo features have been removed from the default set. Users will need to specify which features they depend on in their Cargo.toml.

@stefano-garzarella
Copy link
Member

Build breaks because nix removed all default features and they need to be specified explicitly now:

All Cargo features have been removed from the default set. Users will need to specify which features they depend on in their Cargo.toml.

okay, I'll take a look at that.

@stefano-garzarella
Copy link
Member

Build breaks because nix removed all default features and they need to be specified explicitly now:

All Cargo features have been removed from the default set. Users will need to specify which features they depend on in their Cargo.toml.

okay, I'll take a look at that.

Not sure about the features, I tried to enable all of them for vhost-user-console, but I'm still seeing the same issue, maybe it's related to nix-rust/nix#1906

@stefano-garzarella
Copy link
Member

Build breaks because nix removed all default features and they need to be specified explicitly now:

All Cargo features have been removed from the default set. Users will need to specify which features they depend on in their Cargo.toml.

okay, I'll take a look at that.

Not sure about the features, I tried to enable all of them for vhost-user-console, but I'm still seeing the same issue, maybe it's related to nix-rust/nix#1906

Wrong link in their changelog, I mean this: https://github.com/nix-rust/nix/blob/e8879e310f3f1ca7277588de44204bf14eb1991c/CHANGELOG.md?plain=1#L346

@stefano-garzarella
Copy link
Member

@TimosAmpel can you take a look at this failure updating nix in vhost-user-console?

@epilys
Copy link
Member

epilys commented Sep 2, 2024

Ah yeah, BorrowedFd. From a quick glance we need (at least) two changes:

  • Implement AsFd for EventFd in vmm-sys-util (currently only implements AsRawFd)
  • Use a borrowed fd for stdout

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 9, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Sep 9, 2024
@dependabot dependabot bot deleted the dependabot/cargo/staging/vhost-device-86f30a0df4 branch September 9, 2024 04:44
@stefano-garzarella
Copy link
Member

@TimosAmpel can you take a look at this failure updating nix in vhost-user-console?

@TimosAmpel do you any time for that? I'm not sure why in vhost-user-console we are using a select, and not re-using the epoll from the workers. In other devices we also need to monitor other file descriptors, and we attached them to the worker epoll, maybe we should do the same in the console device too.

@TimosAmpel
Copy link
Contributor

@TimosAmpel can you take a look at this failure updating nix in vhost-user-console?

@TimosAmpel do you any time for that? I'm not sure why in vhost-user-console we are using a select, and not re-using the epoll from the workers. In other devices we also need to monitor other file descriptors, and we attached them to the worker epoll, maybe we should do the same in the console device too.

Hello @stefano-garzarella, @epilys and sorry for the delayed reply.
That's a good idea, I will have a look by the end of the week and check if/how this can be done also for console.

@TimosAmpel
Copy link
Contributor

@stefano-garzarella, I did a draft implementation eliminating the select and use the worker epoll for the nested case.
I am planning early next week to create a new PR targeting to promote console on main workspace and correct any open
point as this one. Would you like to proceed like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants