Skip to content

Update vhost-device-console backend & move it in main workspace #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stsquad merged 3 commits into from
Nov 9, 2024
Merged

Update vhost-device-console backend & move it in main workspace #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93dd6af
vhost-device-console: use worker's epoll for input events
TimosAmpel Oct 10, 2024
0bf48e8
vhost-device-console: improve tests
TimosAmpel Oct 10, 2024
76053f1
vhost-device-console: promote to main workspace
TimosAmpel Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
259 changes: 210 additions & 49 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
resolver = "2"

members = [
"vhost-device-console",
"vhost-device-gpio",
"vhost-device-i2c",
"vhost-device-input",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ To be included here device backends must:

Here is the list of device backends that we support:

- [Console](https://github.com/rust-vmm/vhost-device/blob/main/vhost-device-console/README.md)
- [GPIO](https://github.com/rust-vmm/vhost-device/blob/main/vhost-device-gpio/README.md)
- [I2C](https://github.com/rust-vmm/vhost-device/blob/main/vhost-device-i2c/README.md)
- [Input](https://github.com/rust-vmm/vhost-device/blob/main/vhost-device-input/README.md)
Expand Down Expand Up @@ -48,7 +49,6 @@ Here is the list of device backends in **staging**:

- [Video](https://github.com/rust-vmm/vhost-device/blob/main/staging/vhost-device-video/README.md)
- [Can](https://github.com/rust-vmm/vhost-device/blob/main/staging/vhost-device-can/README.md)
- [Console](https://github.com/rust-vmm/vhost-device/blob/main/staging/vhost-device-console/README.md)

<!--
Template:
Expand Down
199 changes: 12 additions & 187 deletions staging/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion staging/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ resolver = "2"
members = [
"vhost-device-video",
"vhost-device-can",
"vhost-device-console",
]
2 changes: 1 addition & 1 deletion staging/coverage_config_x86_64.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"coverage_score": 80.31,
"coverage_score": 82.00,
"exclude_path": "",
"crate_features": ""
}
0 staging/vhost-device-console/CHANGELOG.md → vhost-device-console/CHANGELOG.md
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion staging/vhost-device-console/Cargo.toml → vhost-device-console/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ xen = ["vm-memory/xen", "vhost/xen", "vhost-user-backend/xen"]
[dependencies]
console = "0.15.7"
crossterm = "0.28.1"
nix = "0.26.4"
queues = "1.0.2"
clap = { version = "4.5", features = ["derive"] }
env_logger = "0.11"
Expand Down
0 staging/vhost-device-console/LICENSE-APACHE → vhost-device-console/LICENSE-APACHE
View file
Open in desktop
File renamed without changes.
0 ...vhost-device-console/LICENSE-BSD-3-Clause → vhost-device-console/LICENSE-BSD-3-Clause
View file
Open in desktop
File renamed without changes.
6 changes: 0 additions & 6 deletions staging/vhost-device-console/README.md → vhost-device-console/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ arguments) and allows input/output to the guest console via that socket.
This program is tested with QEMU's `vhost-user-device-pci` device.
Examples' section below.

## Staging Device
This device will be in `staging` until we complete the following steps:
- [ ] Increase test coverage
- [ ] Support VIRTIO_CONSOLE_F_SIZE feature (optional)
- [ ] Support VIRTIO_CONSOLE_F_EMERG_WRITE feature (optional)

## Synopsis
```text
vhost-device-console --socket-path=<SOCKET_PATH>
Expand Down
Loading