Repository navigation
Windows: Fix Incorrect cursor_range Calculation in Ime::Preedit - #4201
Merged
kchibisov merged 4 commits intoApr 29, 2025
Merged
Conversation
mitoma
force-pushed
the
fix-ime-preedit-on-windows-0.30
branch
from
April 22, 2025 15:07
dad591a to
e2cdeca
Compare
mitoma
force-pushed
the
fix-ime-preedit-on-windows-0.30
branch
2 times, most recently
from
April 29, 2025 06:21
689efa1 to
669086e
Compare
kchibisov
requested changes
Apr 29, 2025
The `text` is retrieved as UTF-8 while `attributes` are based on UTF-16. This commit introduces a mapping between UTF-8 and UTF-16 indices to ensure proper handling of IME composition ranges and cursor positions.
mitoma
force-pushed
the
fix-ime-preedit-on-windows-0.30
branch
from
April 29, 2025 11:04
5aa687f to
14025b4
Compare
kchibisov
requested changes
Apr 29, 2025
kchibisov
left a comment
Member
There was a problem hiding this comment.
looks good, needs a changelog entry, like: On Windows, fix Ime::Preedit cursor offset calculation.
Contributor
Author
|
@kchibisov |
kchibisov
approved these changes
Apr 29, 2025
Member
|
Thanks. |
Member
We generally don't sort alphabetically and entries are in chronological order. Hence why there's no mention of any sorting in changelog.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the Ime::Preedit issue reported in #3967.
The issue arises because text is based on UTF-8 while attribute is based on UTF-16, leading to misalignment in cursor positioning.
changelogmodule if knowledge of this change could be valuable to users