Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3069f61
test: use Multicall from "forge-std"
PaulRBerg Jan 19, 2023
dd3b0b6
build: separate normal from deterministic deployment scripts
PaulRBerg Jan 19, 2023
e3fd376
build: use Forge Std's CREATE2 factory
PaulRBerg Jan 19, 2023
144446c
docs: improve wording in NatSpec comments
PaulRBerg Jan 19, 2023
c2f19aa
build: add gas snapshot
PaulRBerg Jan 19, 2023
e1971d1
build: add gas report and snapshot commands in "package.json"
PaulRBerg Jan 19, 2023
bc252d4
docs: fix contract names in NatSpec comments
PaulRBerg Jan 19, 2023
4d8ae25
refactor: rename "LockupCreateAmounts" to "CreateLockupAmounts"
PaulRBerg Jan 19, 2023
308393d
test: test cancel and withdraw in integration tests
PaulRBerg Jan 20, 2023
f96f2fc
refactor: reference event name in code comments
PaulRBerg Jan 20, 2023
dc33fcb
build: gas snapshot for optimized profile
PaulRBerg Jan 20, 2023
c06185f
test: run tests against deploy scripts
PaulRBerg Jan 20, 2023
ccb7dbd
test: reference event name in all comments
PaulRBerg Jan 20, 2023
80156b1
test: pass "err" string to all assertions
PaulRBerg Jan 20, 2023
24b82b1
chore: commit ".vscode" in version control
PaulRBerg Jan 21, 2023
86b7416
build: regenerate gas snapshot
PaulRBerg Jan 21, 2023
1541752
test: add "_Unit" suffix to all unit test contracts
PaulRBerg Jan 21, 2023
cb5f800
chore: delete stale "ci" Foundry profile
PaulRBerg Jan 21, 2023
4af75ca
test: separate tests in "unit" and "fuzz"
PaulRBerg Jan 22, 2023
b985d26
build: regenerate gas snapshot
PaulRBerg Jan 22, 2023
046eaab
test: rename "integration" to "e2e" tests
PaulRBerg Jan 22, 2023
3c1f312
ci: split "build-and-test" job
PaulRBerg Jan 22, 2023
85e6356
build: ugprade "forge-std" and "prb-math"
PaulRBerg Jan 22, 2023
0f45b48
test: add header separators for shared functions
PaulRBerg Jan 24, 2023
c8d8d0a
test: test all values initialized in constructors
PaulRBerg Jan 24, 2023
77b770f
chore: delete unusable "gas:report:optimized" script
PaulRBerg Jan 24, 2023
1173668
test: nest "test/helpers" under "test/shared"
PaulRBerg Jan 23, 2023
19d22c8
test: move "test/shared/flash-loan" under "test/shared/mockups"
PaulRBerg Jan 24, 2023
f5745f1
ci: re-add weekly fuzz seed
PaulRBerg Jan 24, 2023
3df796c
ci: selective fuzz runs
PaulRBerg Jan 24, 2023
76be144
chore: use "override" specifier in linear
andreivladbrg Jan 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: improve wording in NatSpec comments
  • Loading branch information
PaulRBerg committed Jan 27, 2023
commit 144446ca1a0a1b5cb00f5f51a04aa68a63640dad
4 changes: 2 additions & 2 deletions src/interfaces/hooks/ISablierV2LockupRecipient.sol
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface ISablierV2LockupRecipient {
/// after a cancellation triggered by the sender or an approved operator.
///
/// @dev Notes:
/// - This function may revert, but Sablier V2 will always ignore the revert.
/// - This function may revert, but the {SablierV2Lockup} contract will always ignore the revert.
///
/// @param streamId The id of the stream that was canceled.
/// @param caller The address of the original `msg.sender` address that triggered the cancellation.
Expand All @@ -21,7 +21,7 @@ interface ISablierV2LockupRecipient {
/// @notice Reacts to a withdrawal from a stream.
/// @dev Sablier V2 invokes this function on the recipient after a withdrawal triggered by the sender or
/// an approved operator.
/// This function may revert, but Sablier V2 will always ignore the revert.
/// This function may revert, but the {SablierV2Lockup} contract will always ignore the revert.
/// @param streamId The id of the stream that was canceled.
/// @param caller The address of the original `msg.sender` address that triggered the cancellation.
/// @param amount The amount of assets that have been withdrawn, in units of the asset's decimals.
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/hooks/ISablierV2LockupSender.sol
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface ISablierV2LockupSender {
/// cancellation triggered by the recipient.
///
/// @dev Notes:
/// - This function may revert, but Sablier V2 will always ignore the revert.
/// - This function may revert, but the {SablierV2Lockup} contract will always ignore the revert.
///
/// @param streamId The id of the stream that was canceled.
/// @param caller The address of the original `msg.sender` address that triggered the cancellation.
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Helpers.sol
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ library Helpers {
_checkProSegments(segments, netDepositAmount, startTime);
}

// @dev Checks that the segment array counts match, and then adjusts the segments by calculating the milestones.
/// @dev Checks that the segment array counts match, and then adjusts the segments by calculating the milestones.
function checkDeltasAndAdjustSegments(Segment[] memory segments, uint40[] memory deltas) internal view {
// Checks: check that the segment array counts match.
uint256 deltaCount = deltas.length;
Expand Down