Skip to content

Conversation

@mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Apr 10, 2020

PR #166 is incomplete. It still allows this situation to happen in an infinite loop:

XMLReader::XML(): Empty string supplied as input at \/Users\/mrow4a\/Projects\/www\/octest\/lib\/composer\/sabre\/xml\/lib\/Reader.php#63
XMLReader::read(): Load Data before trying to read at \/Users\/mrow4a\/Projects\/www\/octest\/lib\/composer\/sabre\/xml\/lib\/Reader.php#63
XMLReader::read(): Load Data before trying to read at \/Users\/mrow4a\/Projects\/www\/octest\/lib\/composer\/sabre\/xml\/lib\/Reader.php#63
...

With this MR, now I see exception properly handled:

Exception: {\"Exception\":\"Sabre\\\\
Xml\\\\ParseException\",\"Message\":\"The input element to parse is empty. Do not attempt to parse\",\"Code\":0,\"Trace\":\"#0 \\\/Users\\\/mrow4a\\\/Projects\\\/www\\\/octest\\\/lib\\\/composer\\\/sabre\
\\/dav\\\/lib\\\/DAV\\\/Client.php(419)

@mrow4a
Copy link
Contributor Author

mrow4a commented Apr 10, 2020

@DeepDiver1975 could you have a look?

@mrow4a mrow4a force-pushed the bugfix/empty-input-exception branch from f1bb698 to f03e438 Compare April 10, 2020 16:58
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #183 into master will increase coverage by 4.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
+ Coverage     93.38%   97.61%   +4.22%     
  Complexity      112      112              
============================================
  Files            15       13       -2     
  Lines           484      461      -23     
============================================
- Hits            452      450       -2     
+ Misses           32       11      -21     
Impacted Files Coverage Δ Complexity Δ
lib/Service.php 100.00% <100.00%> (ø) 18.00 <0.00> (ø)
lib/XmlDeserializable.php
lib/Version.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a31ca...f03e438. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants